-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: initialize navbar #19
base: main
Are you sure you want to change the base?
Conversation
Visit the preview URL for this PR (updated for commit 9b59a9b): https://ccv-website-next--pr19-feat-navbar-s44wh82q.web.app (expires Tue, 29 Oct 2024 18:23:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 809aa2d3a6cfe026c3c7417c932015a8f1d9ec89 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The active route for about looks good! And we can talk about subroutes today at our website meeting!
] | ||
const pathname = usePathname() | ||
if (linkType === "mobile") { | ||
//block border-l-4 border-transparent py-2 pl-3 pr-4 text-base font-medium text-gray-600 hover:border-gray-300 hover:bg-gray-50 hover:text-gray-800 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete?
Includes the main routes for the site, but no sub-routes as of yet. Would love to have a conversation about accessible subroute design.
To see what the Navbar link looks like when it is the active route, look at the "About" page, which is the only implemented route at this time.