Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove: delete duplicate electron field in global install in quick_start #142

Merged
merged 6 commits into from
Jul 8, 2024

Conversation

YUUU23
Copy link
Contributor

@YUUU23 YUUU23 commented Jun 20, 2024

  • In quick_start.mdx, remove the duplicate electron field in the global install code instruction

@YUUU23 YUUU23 requested a review from RobertGemmaJr June 20, 2024 21:39
@YUUU23 YUUU23 linked an issue Jun 20, 2024 that may be closed by this pull request
@YUUU23 YUUU23 self-assigned this Jun 21, 2024
Copy link
Member

@RobertGemmaJr RobertGemmaJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YUUU23 Could you send a few screenshots of the quick start guide on your local host? It looks like you're formatter is changing a bunch of stuff. I don't think we have a linter setup for the project right now so that's okay, I just want to make sure everything still looks okay. Especially the tab items around line 175-200

@YUUU23
Copy link
Contributor Author

YUUU23 commented Jun 24, 2024

@RobertGemmaJr
Here are the screenshots of the Quick Start page on my local end (line 175-200 and the duplicated electron issue on this issue should be on page 3 of the screenshots):
PR142.pdf

Let me know if I should change anything! Also, let me know if you think it's easier if I open a new branch and somehow make changes to that line only?
Thank you!

Copy link

github-actions bot commented Jun 26, 2024

Visit the preview URL for this PR (updated for commit e0bc29c):

https://ccv-honeycomb-docs--pr142-rem-duplicate-electr-n5j9jft0.web.app

(expires Fri, 05 Jul 2024 15:59:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d403a110fede5b0308678a87537bf61d0597aef6

@YUUU23 YUUU23 requested a review from RobertGemmaJr June 26, 2024 23:52
@YUUU23
Copy link
Contributor Author

YUUU23 commented Jun 26, 2024

Rebased this branch so that it now includes the firebase preview link

@RobertGemmaJr
Copy link
Member

@YUUU23 Can you bring your local changes on main up to date, checkout this branch, and then do git merge main? It looks like this PR isn't recognizing the changes to Firebase in main

@YUUU23
Copy link
Contributor Author

YUUU23 commented Jun 28, 2024

@RobertGemmaJr I just followed the directions provided and merged main with this branch. Please let me know if anything else needs to be changed.

Copy link
Member

@RobertGemmaJr RobertGemmaJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks cleaning up that merge with main! 🚀

@YUUU23 YUUU23 merged commit bd8b659 into main Jul 8, 2024
3 checks passed
@YUUU23 YUUU23 deleted the rem-duplicate-electron branch July 8, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicate electron field in global install (quick start)
2 participants