-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove: delete duplicate electron field in global install in quick_start #142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YUUU23 Could you send a few screenshots of the quick start guide on your local host? It looks like you're formatter is changing a bunch of stuff. I don't think we have a linter setup for the project right now so that's okay, I just want to make sure everything still looks okay. Especially the tab items around line 175-200
@RobertGemmaJr Let me know if I should change anything! Also, let me know if you think it's easier if I open a new branch and somehow make changes to that line only? |
…omb-docs into deploy-firebase g:wa :qa :q :wq :wq
…/honeycomb-docs into rem-duplicate-electron
Visit the preview URL for this PR (updated for commit e0bc29c): https://ccv-honeycomb-docs--pr142-rem-duplicate-electr-n5j9jft0.web.app (expires Fri, 05 Jul 2024 15:59:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d403a110fede5b0308678a87537bf61d0597aef6 |
Rebased this branch so that it now includes the firebase preview link |
@YUUU23 Can you bring your local changes on |
@RobertGemmaJr I just followed the directions provided and merged main with this branch. Please let me know if anything else needs to be changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks cleaning up that merge with main! 🚀
quick_start.mdx
, remove the duplicate electron field in the global install code instruction