Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Use double quotes #255

Merged
merged 6 commits into from
Jul 20, 2023
Merged

style: Use double quotes #255

merged 6 commits into from
Jul 20, 2023

Conversation

RobertGemmaJr
Copy link
Member

Updates the prettier rules and runs an npm run format

@RobertGemmaJr RobertGemmaJr self-assigned this Jul 19, 2023
@RobertGemmaJr RobertGemmaJr changed the base branch from main to feat-env-config July 19, 2023 19:22
@github-actions
Copy link

github-actions bot commented Jul 19, 2023

Visit the preview URL for this PR (updated for commit c2b9dc4):

https://ccv-honeycomb--pr255-style-dq-2wyazg6s.web.app

(expires Thu, 27 Jul 2023 15:03:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610

Copy link

@anna-murphy anna-murphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just did a quick grep -rn "'" src/ to make sure you didn't miss anything, and I found a few single quotes (outside of comments and not being used as apostrophes). You didn't make any changes there, so I can't suggest in GitHub, but its in src/components/App.jsx and a bunch of instances under src/JsPsych/trials. It might be worth double checking you're linting file is hitting all the places you want?

@RobertGemmaJr
Copy link
Member Author

and a bunch of instances under src/JsPsych/trials.

These are all inside template literal strings so they're not being formatted correctly. I think that's something I'll work on as time goes on? Most of the trials won't be used in the next version of Honeycomb so I think it's safe to leave them. I did go through and catch some more to change though - thank you!

Base automatically changed from feat-env-config to v4 July 20, 2023 14:59
@RobertGemmaJr RobertGemmaJr merged commit 0e4ae36 into v4 Jul 20, 2023
10 checks passed
@RobertGemmaJr RobertGemmaJr deleted the style-dq branch July 20, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants