-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: Use double quotes #255
Conversation
Visit the preview URL for this PR (updated for commit c2b9dc4): https://ccv-honeycomb--pr255-style-dq-2wyazg6s.web.app (expires Thu, 27 Jul 2023 15:03:29 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just did a quick grep -rn "'" src/
to make sure you didn't miss anything, and I found a few single quotes (outside of comments and not being used as apostrophes). You didn't make any changes there, so I can't suggest in GitHub, but its in src/components/App.jsx
and a bunch of instances under src/JsPsych/trials
. It might be worth double checking you're linting file is hitting all the places you want?
These are all inside template literal strings so they're not being formatted correctly. I think that's something I'll work on as time goes on? Most of the trials won't be used in the next version of Honeycomb so I think it's safe to leave them. I did go through and catch some more to change though - thank you! |
Updates the prettier rules and runs an
npm run format