Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix file saving in electron.js #259

Merged
merged 2 commits into from
Aug 15, 2023
Merged

fix: Fix file saving in electron.js #259

merged 2 commits into from
Aug 15, 2023

Conversation

RobertGemmaJr
Copy link
Member

@RobertGemmaJr RobertGemmaJr commented Aug 7, 2023 •
edited
Loading

  • Fix file saving in electron.js with fs.mkdirsync
  • Upgrade firebase and firebaswe-tools deps to latest versions
  • Upgrade eslint-config-prettier to lastest version
  • Adds brew lockfile to Gitignore

@RobertGemmaJr RobertGemmaJr self-assigned this Aug 7, 2023
@RobertGemmaJr RobertGemmaJr added bug Something isn't working high priority Issue to be completed asap labels Aug 7, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit abe7a34):

https://ccv-honeycomb--pr259-fix-file-saving-3xr2upb6.web.app

(expires Mon, 14 Aug 2023 19:13:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610

hetd54
hetd54 approved these changes Aug 15, 2023
View reviewed changes
Copy link

@hetd54 hetd54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! I have a question above for my own learning.

public/electron.js
} catch (e) {
console.error('Unable to save file: ', fullPath);
console.error(e);
log.error(e);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does log.error do that console.error doesn't? might need to add to my toolbelt!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a special logging tool needed by electron. https://www.npmjs.com/package/electron-log

@RobertGemmaJr RobertGemmaJr merged commit 389cea6 into main Aug 15, 2023
10 checks passed
@RobertGemmaJr RobertGemmaJr deleted the fix-file-saving branch August 15, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hetd54 hetd54 hetd54 approved these changes

@mirestrepo mirestrepo Awaiting requested review from mirestrepo

@anna-murphy anna-murphy Awaiting requested review from anna-murphy

@broarr broarr Awaiting requested review from broarr

Assignees

@RobertGemmaJr RobertGemmaJr

Labels
bug Something isn't working high priority Issue to be completed asap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertGemmaJr @hetd54