chore: logging 3 - remove prints from tools directory #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hollandjg
changed the base branch from
main
to
feat-logger/2-replace-print-logger-analysis_db
hollandjg
requested review from
mochell,
cpaniaguam and
kmilo9999
and removed request for
mochell
cpaniaguam
requested changes
Mar 5, 2024
Co-authored-by: Carlos Paniagua <[email protected]>
Co-authored-by: Carlos Paniagua <[email protected]>
…at-logger/3-replace-print-logger-tools # Conflicts: # src/icesat2_tracks/ICEsat2_SI_tools/angle_optimizer.py # src/icesat2_tracks/ICEsat2_SI_tools/filter_regrid.py # src/icesat2_tracks/ICEsat2_SI_tools/spectral_estimates.py # src/icesat2_tracks/ICEsat2_SI_tools/spicke_remover.py # src/icesat2waves/tools/iotools.py # src/icesat2waves/tools/sliderule_converter_tools.py
…at-logger/3-replace-print-logger-tools
…at-logger/3-replace-print-logger-tools
kmilo9999
previously approved these changes
Mar 18, 2024
…at-logger/3-replace-print-logger-tools
Base automatically changed from
feat-logger/2-replace-print-logger-analysis_db
to
main
March 20, 2024 17:03
hollandjg
dismissed stale reviews from kmilo9999 and cpaniaguam
The base branch was changed.
cpaniaguam
requested changes
Mar 20, 2024
| @@ -328,7 +332,7 @@ def ATL03_download(username, password, dpath, product_directory, sd, file_name): | |||
| """ | |||
|
|
|||
| HOST = ["https://n5eil01u.ecs.nsidc.org", "ATLAS", product_directory, sd, file_name] | |||
| print("download to:", dpath + "/" + HOST[-1]) | |||
| _logger.debug("download to: %s", dpath + "/" + HOST[-1]) | |||
There was a problem hiding this comment.
Fewer characters, same result. Thoughts?
Suggested change
| _logger.debug("download to: %s", dpath + "/" + HOST[-1]) | |
| _logger.debug("download to: %s", dpath"/"HOST[-1]) |
There was a problem hiding this comment.
Wow, that works? It looks like a syntax error to me. I didn't know you could concatenate strings that way. How does Black reformat it? I'm not super keen – I don't think the suggestion makes the syntax any clearer.
There was a problem hiding this comment.
Maybe it doesn't work. I guess it only works with literals.
Co-authored-by: Carlos Paniagua <[email protected]>
cpaniaguam
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.