chore: logging 5 - remove prints from local_modules directory #179

hollandjg · 2024-03-04T23:26:47Z

Builds on

chore: logging 4 – remove prints from config directory #178

resolves #196

cpaniaguam

Thanks for your contributions, John! I pointed some issues with updates to commented lines that seem to have been changed programmatically. What to do with them? If they are kept and used later, extra work would be needed to make the messages lazily evaluated. I also noted a number of specific opportunities for improvement.

src/icesat2_tracks/local_modules/JONSWAP_gamma.py

src/icesat2_tracks/local_modules/m_colormanager_ph3.py

src/icesat2_tracks/local_modules/m_spectrum_ph3.py

src/icesat2_tracks/local_modules/m_tools_ph3.py

hollandjg · 2024-03-05T20:48:23Z

If they are kept and used later, extra work would be needed to make the messages lazily evaluated.

I agree. A lot of these lines are also touched in #131 (and a lot will be removed), so I don't want to make all the corrections just yet. Once we see what the final merge looks like we can revisit here.

I'm also mindful of the extra effort going through and fixing commented out code might add, and I feel like we're close to the point of diminishing returns here. (There's a strong argument that we hit that point two weeks ago when you said this would be too much work – it's been more work than I expected.)

kmilo9999

Looks good to me

…gger/5-replace-print-logger-local_modules # Conflicts: # src/icesat2waves/local_modules/m_colormanager_ph3.py

…gger/5-replace-print-logger-local_modules

…gger/5-replace-print-logger-local_modules # Conflicts: # src/icesat2waves/local_modules/jonswap_gamma.py # src/icesat2waves/local_modules/m_colormanager_ph3.py # src/icesat2waves/local_modules/m_general_ph3.py # src/icesat2waves/local_modules/m_spectrum_ph3.py # src/icesat2waves/local_modules/m_tools_ph3.py

add more context to debug messages Co-Authored-By: Carlos Paniagua <[email protected]>

Co-Authored-By: Carlos Paniagua <[email protected]>

…er-local_modules' into feat-logger/5-replace-print-logger-local_modules

Co-authored-by: Carlos Paniagua <[email protected]>

cpaniaguam

Just two observations.

cpaniaguam · 2024-03-15T16:58:37Z

src/icesat2waves/local_modules/m_general_ph3.py

+            _logger.debug("self.iter")
            self.iter.__dict__
        if self.iter2 is not None:
-            print("self.iter2")
+            _logger.debug("self.iter2")


Maybe something like _logger.debug("iter2: %s", self.iter2)? I don't think the current version is very useful as the value of the variable is not displayed.

src/icesat2waves/local_modules/m_tools_ph3.py

src/icesat2waves/local_modules/m_general_ph3.py

kmilo9999

Looks good to me. There is small change I suggested

Co-authored-by: Carlos Paniagua <[email protected]>

Co-authored-by: Camilo Diaz <[email protected]>

Co-Authored-By: Carlos Paniagua <[email protected]>

…tps://github.com/brown-ccv/icesat2waves into feat-logger/5-replace-print-logger-local_modules

cpaniaguam

I think this one has a couple broken ones mixing f-strings with %s. I added suggestions with potential fixes.

src/icesat2waves/local_modules/m_general_ph3.py

src/icesat2waves/local_modules/m_tools_ph3.py

Co-authored-by: Carlos Paniagua <[email protected]>

…gger/5-replace-print-logger-local_modules

cpaniaguam

Thanks!

…gger/5-replace-print-logger-local_modules

The base branch was changed.

…ules

hollandjg added 5 commits March 4, 2024 18:23

chore: replace print with logging in JONSWAP_gamma.py

01fce88

chore: replace print with logging in m3_colormanager_ph3.py

7430f57

chore: replace print with logging in m_general_ph3.py

9da6708

chore: replace print with logging in m_spectrum_ph3

2cefaf5

chore: replace print with logging in m_tools_ph3.py

39babe5

hollandjg mentioned this pull request Mar 4, 2024

feat: combine all logger PRs #168

Closed

hollandjg requested review from cpaniaguam and kmilo9999 March 4, 2024 23:34

hollandjg marked this pull request as ready for review March 4, 2024 23:39

cpaniaguam requested changes Mar 5, 2024

View reviewed changes

kmilo9999 approved these changes Mar 6, 2024

View reviewed changes

hollandjg added 2 commits March 11, 2024 16:05

Merge branch 'feat-logger/4-replace-print-logger-config' into feat-lo…

ed8ee0c

…gger/5-replace-print-logger-local_modules # Conflicts: # src/icesat2waves/local_modules/m_colormanager_ph3.py

Merge branch 'feat-logger/4-replace-print-logger-config' into feat-lo…

f7b3a5c

…gger/5-replace-print-logger-local_modules

This was referenced Mar 12, 2024

Stuff like this can be done with a single call to print but it'd take extra work to add logging. #196

Closed

Clean files in local_modules #131

Merged

hollandjg and others added 7 commits March 13, 2024 16:44

fix: update formatting in logging

5d220d3

fix: reformat debugs from prints

397c300

revert change to boot.ci call

044db60

fix: replace evaluated strings

5911294

chore: remove unused from __future__ import

063c21e

make updates from PR review

f33a6fb

add more context to debug messages Co-Authored-By: Carlos Paniagua <[email protected]>

hollandjg mentioned this pull request Mar 13, 2024

The elif branch does the same work as the else branch but this is for a different PR. #197

Open

hollandjg and others added 4 commits March 13, 2024 18:15

Added more context

277bca8

Co-Authored-By: Carlos Paniagua <[email protected]>

Updates from PR review

c3dcebd

Co-Authored-By: Carlos Paniagua <[email protected]>

Updates from PR review

0399770

Co-Authored-By: Carlos Paniagua <[email protected]>

Updates from PR review

b9360de

Co-Authored-By: Carlos Paniagua <[email protected]>

hollandjg requested review from cpaniaguam and kmilo9999 March 13, 2024 22:22

hollandjg and others added 4 commits March 15, 2024 11:24

chore: reordered and deduplicated logging calls

7799236

chore: add more logging context

01cc041

Merge remote-tracking branch 'origin/feat-logger/5-replace-print-logg…

5501bfc

…er-local_modules' into feat-logger/5-replace-print-logger-local_modules

Update src/icesat2waves/local_modules/m_colormanager_ph3.py

63a00d0

Co-authored-by: Carlos Paniagua <[email protected]>

hollandjg requested a review from cpaniaguam March 15, 2024 15:30

cpaniaguam requested changes Mar 15, 2024

View reviewed changes

kmilo9999 reviewed Mar 18, 2024

View reviewed changes

src/icesat2waves/local_modules/m_general_ph3.py Outdated Show resolved Hide resolved

kmilo9999 previously approved these changes Mar 18, 2024

View reviewed changes

hollandjg and others added 4 commits March 18, 2024 18:02

Update src/icesat2waves/local_modules/m_tools_ph3.py

07d2190

Co-authored-by: Carlos Paniagua <[email protected]>

Update src/icesat2waves/local_modules/m_general_ph3.py

f514e3c

Co-authored-by: Camilo Diaz <[email protected]>

update debugging calls with iter.

d4b31bc

Co-Authored-By: Carlos Paniagua <[email protected]>

Merge branch 'feat-logger/5-replace-print-logger-local_modules' of ht…

eda0e16

…tps://github.com/brown-ccv/icesat2waves into feat-logger/5-replace-print-logger-local_modules

hollandjg requested a review from cpaniaguam March 18, 2024 17:17

cpaniaguam requested changes Mar 19, 2024

View reviewed changes

hollandjg and others added 5 commits March 19, 2024 14:42

Update src/icesat2waves/local_modules/m_general_ph3.py

e105dde

Co-authored-by: Carlos Paniagua <[email protected]>

Update src/icesat2waves/local_modules/m_tools_ph3.py

fa7b492

Co-authored-by: Carlos Paniagua <[email protected]>

Update src/icesat2waves/local_modules/m_tools_ph3.py

c80198d

Co-authored-by: Carlos Paniagua <[email protected]>

Update src/icesat2waves/local_modules/m_general_ph3.py

52c7320

Co-authored-by: Carlos Paniagua <[email protected]>

Update src/icesat2waves/local_modules/m_general_ph3.py

ece4f27

Co-authored-by: Carlos Paniagua <[email protected]>

hollandjg requested a review from cpaniaguam March 19, 2024 14:01

Merge branch 'feat-logger/4-replace-print-logger-config' into feat-lo…

d2d12e0

…gger/5-replace-print-logger-local_modules

cpaniaguam previously approved these changes Mar 19, 2024

View reviewed changes

hollandjg added 2 commits March 20, 2024 18:03

Merge branch 'feat-logger/4-replace-print-logger-config' into feat-lo…

8afc4a7

…gger/5-replace-print-logger-local_modules

Merge branch 'feat-logger/4-replace-print-logger-config' into feat-lo…

d2ab30e

…gger/5-replace-print-logger-local_modules

Base automatically changed from feat-logger/4-replace-print-logger-config to main March 22, 2024 14:11

Merge branch 'main' into feat-logger/5-replace-print-logger-local_mod…

2c472f8

…ules

hollandjg merged commit b032621 into main Mar 22, 2024
2 checks passed

hollandjg deleted the feat-logger/5-replace-print-logger-local_modules branch March 22, 2024 14:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: logging 5 - remove prints from local_modules directory #179

chore: logging 5 - remove prints from local_modules directory #179

hollandjg commented Mar 4, 2024 •

edited

Loading

cpaniaguam left a comment

hollandjg commented Mar 5, 2024

kmilo9999 left a comment

cpaniaguam left a comment

cpaniaguam Mar 15, 2024

kmilo9999 left a comment •

edited

Loading

cpaniaguam left a comment

cpaniaguam left a comment

chore: logging 5 - remove prints from local_modules directory #179

chore: logging 5 - remove prints from local_modules directory #179

Conversation

hollandjg commented Mar 4, 2024 • edited Loading

cpaniaguam left a comment

Choose a reason for hiding this comment

hollandjg commented Mar 5, 2024

kmilo9999 left a comment

Choose a reason for hiding this comment

cpaniaguam left a comment

Choose a reason for hiding this comment

cpaniaguam Mar 15, 2024

Choose a reason for hiding this comment

kmilo9999 left a comment • edited Loading

Choose a reason for hiding this comment

cpaniaguam left a comment

Choose a reason for hiding this comment

cpaniaguam left a comment

Choose a reason for hiding this comment

hollandjg commented Mar 4, 2024 •

edited

Loading

kmilo9999 left a comment •

edited

Loading