This repository has been archived by the owner on Dec 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visit the preview URL for this PR (updated for commit 94a0bbb): https://mmp-site-b1c9b--pr40-data-page-init-oz32lhid.web.app (expires Thu, 09 May 2024 18:42:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4eb870c89e876f1812e204af417359065d2a23b1 |
galenwinsor
suggested changes
May 1, 2024
galenwinsor
approved these changes
May 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #9 & #20
Changed
admin/config.yml: put uploaded files in the public/files directory so we can eventually have folks download selected files
DownloadModal: Button to show modal now has text for visibility
src/content/config.ts: added the file data collection for typing
data.astro: Added new component, load and pass file data collection as props
global.css: Add some explicit styles for tables and checkboxes
Added
DataTable component: Table of downloadable files which are uploaded by admins in staticCMS; features a 'check all' checkbox. Doesn't currently save this anywhere!
To do in upcoming PRs