Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gcd operation? are the signatures the way we want? #1427

Open
wants to merge 1 commit into
base: horizon
Choose a base branch
from

Conversation

blerner
Copy link
Member

@blerner blerner commented Nov 6, 2018

Just adding a num-gcd method to Pyret since it's missing. But do we need the array argument to jsnums.gcd, since we never even called that function prior to this PR, and we're only calling it with a single argument here? @ds26gte did you need that array for spyret or wescheme or some other racket support?

Copy link
Member

@jpolitz jpolitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some tests in test-numbers so we can make sure it doesn't regress in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants