[Draft] Anchor: highlighting error locations #1679
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would love some help understanding the error message tree that comes back from the compiler so that I can improve a couple cases where the Anchor UI shows message that don't clearly highlight the relevant source location.
Here's one case where the error has a
loc
but not ahighlight
and so it was showing very little detail on where the actual problem was. I've temporarily just copied a lot of the highlight-related code into this case, but I imagine there is a much better way to do this, either by changing the compiler error to emit ahighlight
in this case, or by some broader refactoring to how Anchor handles displayingsrcloc
s.Preview