-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move extract and observe to page #329
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2dac663 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
seanmcguire12
approved these changes
Dec 23, 2024
sameelarif
approved these changes
Dec 23, 2024
This was referenced Dec 23, 2024
Merged
kamath
added a commit
that referenced
this pull request
Dec 24, 2024
* Use CI on v2 branch * branch * add docs, move scoring functions to scoring.ts, move experiment naming to utils.ts * add initStagehand.ts * break up index.evals.ts and utils into smaller files * export LogLineEval * typing * follow StagehandConfig pattern * choose api key based on model name * stagehand.act -> page.act (#326) * need to actually move to act to page now * move act -> page * fix e2e * fix tests * readme * changeset * package json and changeset * don't fail on combo evals * Add act evals on `stagehand.page` (#328) * move act evals to stagehand.page * add basic act and make act necessary in type * move extract and observe to page (#329) * move act evals to stagehand.page * add basic act and make act necessary in type * move extract and observe * example * changeset * More playwright tests (#330) * add docs, move scoring functions to scoring.ts, move experiment naming to utils.ts * add initStagehand.ts * break up index.evals.ts and utils into smaller files * export LogLineEval * typing * follow StagehandConfig pattern * choose api key based on model name * Use CI on v2 branch * branch * stagehand.page tests * dont run on BB * prettier * pls dont fail * headless --------- Co-authored-by: Anirudh Kamath <[email protected]> * add extract evals for stagehand.page (#331) * add extract evals for stagehand.page * fix typign * smh i didn't actually run extract * add observe page evals (#332) * change stagehand.observe to stagehand.page.observe in evals * changeset * Browsercontext playwright tests (#334) * add docs, move scoring functions to scoring.ts, move experiment naming to utils.ts * add initStagehand.ts * break up index.evals.ts and utils into smaller files * export LogLineEval * typing * follow StagehandConfig pattern * choose api key based on model name * Use CI on v2 branch * branch * BrowserContext tests * file path --------- Co-authored-by: Anirudh Kamath <[email protected]> * changeset minor * ci yml --------- Co-authored-by: seanmcguire12 <[email protected]> Co-authored-by: Sean McGuire <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
Follows the pattern of #326 to move extract and observe to the Page object
what changed
stagehand.extract
andstagehand.observe
are now deprecated in favor ofstagehand.page.extract
andstagehand.page.observe
test plan
evals. need a fast-follow PR like #328 for evals moving to
page