prune an empty \bibitem when auto-opened without need #2409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2403
With Bruce's help, I zeroed in on the cause of the issue, namely
\par@in@bibliography
. That code, which defensively auto-opens a\bibitem
, recognizes too few of the legitimate cases with macro use (as described in the issue).Since it is rather high difficulty to both handle "sloppy" uses of
{thebibliography}
as well as the advanced macro uses before a real\bibitem
, this PR resigns to undoing the error after it is caused.Namely, this first stab suggests to check in the
afterDigest
hook of\lx@bibitem
whether the previous recorded box was an empty use of\bibitem
. In the case it was, the assembled previous box is pruned from the digested list, and itsRefStepID
is reused.Seems to work well on the few cases I tried, open to adjustments.