Grant/bru-1049 #16
Grant/bru-1049 #16
Conversation
Add relations module in backend
Add support for generated relations
| @@ -2,3 +2,5 @@ export * from "./database"; | |||
| export * from "./table"; | |||
| export * from "./user-query"; | |||
| export * from "./postgres-adapter"; | |||
| export * from "./relation"; | |||
| export * from "./pipeline"; | |||
There was a problem hiding this comment.
We likely want to change the name pipeline given this new context. What do you think? Is there clearly better name or is this good enough?
There was a problem hiding this comment.
Some options:
- JsonQuery
- StepQuery
- PreQuery
- PreSQL
- ProtoSQL
- ProtoQuery
|
|
||
| // A relation used in a pipeline. Includes the API path to the relation from the base object defintiion and the object definition ID of the related object defintion | ||
| export const InferredSchemaRelationSchema = z.object({ | ||
| api_path: z.string(), |
There was a problem hiding this comment.
Is API path still relevant?
There was a problem hiding this comment.
It is not. Additional changes to these schemas and types (including removing unneeded ones) will be made as part of the query builder PR.
| // A relation used in a pipeline. Includes the API path to the relation from the base object defintiion and the object definition ID of the related object defintion | ||
| export const InferredSchemaRelationSchema = z.object({ | ||
| api_path: z.string(), | ||
| object_definition_id: z.string(), |
There was a problem hiding this comment.
This is definitely not relevant anymore
There was a problem hiding this comment.
Agreed. We'll have a new object for inferred schema relations as part of query builder.
| assert(database, "Database not found"); | ||
|
|
||
| try { | ||
| const result = await client.query( |
There was a problem hiding this comment.
May be worth commenting this, at least what the expected Val is cause it's pretty impossible to tell just by reading it
| tc.table_name, | ||
| tc.constraint_type, | ||
| kcu.column_name;`, | ||
| [database.schema || "public"], |
There was a problem hiding this comment.
we'll need to update this since we're using multiple schema now.
Let's talk about this.
Implement table relations creation.