Tevon/add query params #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 29, 2024 15:22
glpierce
suggested changes
Apr 1, 2024
| const matches = sql.match(/{{(.*?)}}/g); | ||
| let paramIndex = 1; | ||
| const params: any[] = []; | ||
| console.log("Matches", matches); |
| @@ -71,6 +78,7 @@ const Page: React.FC<UserQueryPageProps> = ({ params: { userQueryId } }) => { | |||
| return ( | |||
| <div className="flex flex-col h-full"> | |||
| <QueryHeader query={userQuery} /> | |||
| <QueryParameters parameters={parameters} setParameters={setParameters} /> | |||
There was a problem hiding this comment.
Would be good to merge master into this branch to see how this component interacts with the Pipelin/SQL tabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding parameters to queries.
These can be added at the top of the query page, including a description, name, default value.
Then these are saved to the query when they user selects save and run.
These are passed into the query/run method as query params, which are then added to the query via prepared statements.