Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant/bru-1060 #31

Merged
merged 12 commits into from
Apr 5, 2024
Merged

Grant/bru-1060 #31

merged 12 commits into from
Apr 5, 2024

Conversation

glpierce
Copy link
Contributor

@glpierce glpierce commented Apr 3, 2024

Implement relate step & take step for query builder

@glpierce glpierce added the wip Work in progress label Apr 3, 2024
@glpierce glpierce removed the wip Work in progress label Apr 5, 2024
@glpierce glpierce marked this pull request as ready for review April 5, 2024 03:31
@glpierce glpierce requested a review from tevonsb April 5, 2024 03:31
Copy link
Contributor

@tevonsb tevonsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some small changes! Feel free to make in separate branch if want to get this merged, not functional differences

join side:left {{ relation }} (this.{{ baseJoinColumn }}=={{ relation }}.{{ relationJoinColumn }})
)`;

const relateTemplateManyToMany = `
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are really pretty, nicely done

@glpierce glpierce merged commit 7367905 into master Apr 5, 2024
2 checks passed
@glpierce glpierce deleted the grant/bru-1060 branch April 5, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants