Move the schema field from database to table model #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glpierce
approved these changes
Apr 11, 2024
Comment on lines
-25
to
-36
| if (column.table === "aggregate") { | ||
| return column.name; | ||
| } | ||
|
|
||
| // If the column was added via relation, prefix it with the relation name | ||
| if (column.relation) { | ||
| return `${column.relation.as}__${column.name}`; | ||
| } | ||
|
|
||
| // Otherwise, prefix it with its base table name | ||
| const table = _.find(tables, (table) => table.id === column.table); | ||
| assert(table, `Table not found: ${column.table}`); |
There was a problem hiding this comment.
do we not need this anymore?
There was a problem hiding this comment.
It's been moved into a utils function (generateColumnName) since it's used in a bunch of places!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the schema field from the database model to the table model, enabling cross-schema queries.
The database will need to be migrated to update to the new version with the schema removed.