Skip to content

Commit

Permalink
test: remove unnecessary disconnect_p2ps calls in p2p_sendtxrcncl
Browse files Browse the repository at this point in the history
  • Loading branch information
brunoerg committed Sep 25, 2024
1 parent 3499e0a commit 978bbef
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions test/functional/p2p_sendtxrcncl.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,19 +146,16 @@ def run_test(self):
peer = self.nodes[0].add_outbound_p2p_connection(
SendTxrcnclReceiver(), wait_for_verack=True, p2p_idx=0, connection_type="addr-fetch")
assert not peer.sendtxrcncl_msg_received
self.nodes[0].disconnect_p2ps()

self.log.info('SENDTXRCNCL not sent if -txreconciliation flag is not set')
self.restart_node(0, [])
peer = self.nodes[0].add_p2p_connection(SendTxrcnclReceiver(), send_version=True, wait_for_verack=True)
assert not peer.sendtxrcncl_msg_received
self.nodes[0].disconnect_p2ps()

self.log.info('SENDTXRCNCL not sent if blocksonly is set')
self.restart_node(0, ["-txreconciliation", "-blocksonly"])
peer = self.nodes[0].add_p2p_connection(SendTxrcnclReceiver(), send_version=True, wait_for_verack=True)
assert not peer.sendtxrcncl_msg_received
self.nodes[0].disconnect_p2ps()

# Check everything concerning *receiving* SENDTXRCNCL
# First, receiving from *inbound*.
Expand All @@ -177,7 +174,6 @@ def run_test(self):
peer = self.nodes[0].add_p2p_connection(PeerNoVerack(), send_version=True, wait_for_verack=False)
with self.nodes[0].assert_debug_log(['ignored, as our node does not have txreconciliation enabled']):
peer.send_message(create_sendtxrcncl_msg())
self.nodes[0].disconnect_p2ps()

self.restart_node(0, ["-txreconciliation"])

Expand Down

0 comments on commit 978bbef

Please sign in to comment.