Fixing review comments

bruntib · Aug 14, 2024 · 2d6e333 · 2d6e333
1 parent 440a90b
commit 2d6e333
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 28 deletions.
diff --git a/analyzer/codechecker_analyzer/analyzers/clangsa/analyzer.py b/analyzer/codechecker_analyzer/analyzers/clangsa/analyzer.py
@@ -51,7 +51,7 @@ def parse_clang_help_page(
         help_page = subprocess.check_output(
             command,
             stderr=subprocess.STDOUT,
-            env=analyzer_context.get_context()\
+            env=analyzer_context.get_context()
             .get_analyzer_env(ClangSA.ANALYZER_NAME),
             universal_newlines=True,
             encoding="utf-8",
@@ -208,7 +208,7 @@ def ctu_capability(cls):
         if not cls.__ctu_autodetection:
             cls.__ctu_autodetection = CTUAutodetection(
                 cls.analyzer_binary(),
-                analyzer_context.get_context()\
+                analyzer_context.get_context()
                 .get_analyzer_env(ClangSA.ANALYZER_NAME))
 
         return cls.__ctu_autodetection

diff --git a/analyzer/codechecker_analyzer/analyzers/cppcheck/analyzer.py b/analyzer/codechecker_analyzer/analyzers/cppcheck/analyzer.py
@@ -13,7 +13,6 @@
 from packaging.version import Version
 from pathlib import Path
 import os
-import pickle
 import re
 import shlex
 import shutil
@@ -272,18 +271,6 @@ def get_checker_config(cls):
         """
         return []
 
-    def analyze(self, analyzer_cmd, res_handler, proc_callback=None, _=None):
-        environment = None
-
-        original_env_file = os.environ.get(
-            'CODECHECKER_ORIGINAL_BUILD_ENV')
-        if original_env_file:
-            with open(original_env_file, 'rb') as env_file:
-                environment = pickle.load(env_file, encoding='utf-8')
-
-        return super().analyze(
-            analyzer_cmd, res_handler, proc_callback, environment)
-
     def post_analyze(self, result_handler):
         """
         Post process the reuslts after the analysis.

diff --git a/analyzer/codechecker_analyzer/analyzers/gcc/analyzer.py b/analyzer/codechecker_analyzer/analyzers/gcc/analyzer.py
@@ -7,8 +7,6 @@
 # -------------------------------------------------------------------------
 from collections import defaultdict
 from packaging.version import Version
-import os
-import pickle
 import shlex
 import subprocess
 
@@ -132,17 +130,6 @@ def get_checker_config(cls):
         # TODO
         return []
 
-    def analyze(self, analyzer_cmd, res_handler, proc_callback=None, _=None):
-        env = None
-
-        original_env_file = os.environ.get(
-            'CODECHECKER_ORIGINAL_BUILD_ENV')
-        if original_env_file:
-            with open(original_env_file, 'rb') as env_file:
-                env = pickle.load(env_file, encoding='utf-8')
-
-        return super().analyze(analyzer_cmd, res_handler, proc_callback, env)
-
     def post_analyze(self, result_handler: GccResultHandler):
         """
         Post process the reuslts after the analysis.