Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use assertEqual instead of assertEquals for Python 3.11 compatibility. #358

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tirkarthi
Copy link

Description

The deprecated aliases were removed in Python 3.11 in python/cpython#28268 . Hence use assertEquals .

Fixes #278

Type of change

Please delete options that are not relevant.

  • New algorithm or support class.
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. If you haven't added any test and it is relevant provide instructions so we can reproduce.

  • I have added a new test file: [E.g. test_rf.py]
  • I have added a new test case: [E.g. RFTest.test_make_classification]
  • I have tested it manually in a local environment.
  • I have tested it manually in a supercomputer.

Reproduce instructions:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas.
  • I have documented the public methods of any public class according to the guide styles.
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • I have rebased my branch before trying to merge.

@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #358 (fdec263) into master (56209f1) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
+ Coverage   97.76%   97.81%   +0.04%     
==========================================
  Files          42       42              
  Lines        4529     4529              
==========================================
+ Hits         4428     4430       +2     
+ Misses        101       99       -2     
Impacted Files Coverage Δ
dislib/data/array.py 96.98% <0.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56209f1...fdec263. Read the comment docs.

@cTatu cTatu added this to the release 0.8 milestone Oct 10, 2022
@cTatu cTatu removed this from the release 0.8 milestone Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change assertEquals for assertEqual in KFold tests
2 participants