Extract function to calculate acceptable ranges for node group

cluster-autoscaler/clusterstate/clusterstate.go

@@ -555,25 +555,26 @@ type AcceptableRange struct {
 func (csr *ClusterStateRegistry) updateAcceptableRanges(targetSize map[string]int) {
 	result := make(map[string]AcceptableRange)
 	for _, nodeGroup := range csr.cloudProvider.NodeGroups() {
-		size := targetSize[nodeGroup.Id()]
-		readiness := csr.perNodeGroupReadiness[nodeGroup.Id()]
-		result[nodeGroup.Id()] = AcceptableRange{
-			MinNodes:      size - len(readiness.LongUnregistered),
-			MaxNodes:      size,
-			CurrentTarget: size,
-		}
+		result[nodeGroup.Id()] = csr.acceptableRangeForNodeGroup(targetSize[nodeGroup.Id()], nodeGroup.Id())
 	}
-	for nodeGroupName, scaleUpRequest := range csr.scaleUpRequests {
-		acceptableRange := result[nodeGroupName]
-		acceptableRange.MinNodes -= scaleUpRequest.Increase
-		result[nodeGroupName] = acceptableRange
+	csr.acceptableRanges = result
+}
+
+func (csr *ClusterStateRegistry) acceptableRangeForNodeGroup(targetSize int, nodeGroupId string) AcceptableRange {
+	longUnregistered := 0
+	if readiness, found := csr.perNodeGroupReadiness[nodeGroupId]; found {
+		longUnregistered = len(readiness.LongUnregistered)
 	}
-	for nodeGroupName, scaleDownRequests := range csr.scaleDownRequests {
-		acceptableRange := result[nodeGroupName]
-		acceptableRange.MaxNodes += len(scaleDownRequests)
-		result[nodeGroupName] = acceptableRange
+	ar := AcceptableRange{
+		MinNodes:      targetSize - longUnregistered,
+		MaxNodes:      targetSize,
+		CurrentTarget: targetSize,
 	}
-	csr.acceptableRanges = result
+	if scaleUpRequest, found := csr.scaleUpRequests[nodeGroupId]; found {
+		ar.MinNodes -= scaleUpRequest.Increase
+	}
+	ar.MaxNodes += len(csr.scaleDownRequests[nodeGroupId])
+	return ar
 }
 
 // Readiness contains readiness information about a group of nodes.