Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Added Frontend Origin in CORS whitelist #114

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Fix: Added Frontend Origin in CORS whitelist #114

merged 3 commits into from
Jan 26, 2024

Conversation

ChaudharyRaman
Copy link
Collaborator

Overview

  1. This PR fixes or fixes part of [BUG]: change cors whitelist to allow frontend deployment #111 .
  2. This PR does the following: [Explain here what your PR does and why]

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
  • The PR is made from a branch that's not called "main/master".

Proof that changes are correct

PR Pointers

  • If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL".
  • Never force push. If you do, your PR will be closed.

@netlify Netlify
Copy link

netlify bot commented Dec 29, 2023 •
edited
Loading

✅ Deploy Preview for merch-site canceled.

Name Link
🔨 Latest commit 19270a0
🔍 Latest deploy log https://app.netlify.com/sites/merch-site/deploys/65b38dcc809674000879bb0f

@arminpatel arminpatel self-requested a review December 30, 2023 06:00
@arminpatel arminpatel merged commit b7ae850 into bsoc-bitbyte:main Jan 26, 2024
4 of 6 checks passed
arminpatel added a commit to arminpatel/GetIt that referenced this pull request Jan 26, 2024
@ChaudharyRaman @arminpatel
Fix: Added Frontend Origin in CORS whitelist (bsoc-bitbyte#114)
ca51acf 
* fix:cors

* added frontend origin

* added deploy-previews to cors whitelist

---------

Co-authored-by: Armin Patel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arminpatel arminpatel arminpatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChaudharyRaman @arminpatel