Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.py #122

Merged
merged 3 commits into from
Jan 27, 2024
Merged

Update build.py #122

merged 3 commits into from
Jan 27, 2024

Conversation

arminpatel
Copy link
Collaborator

Overview

  1. This PR fixes or fixes part of #[fill_in_number_here].
  2. This PR does the following: [Explain here what your PR does and why]

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
  • The PR is made from a branch that's not called "main/master".

Proof that changes are correct

PR Pointers

  • If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL".
  • Never force push. If you do, your PR will be closed.

Copy link

netlify bot commented Jan 27, 2024

Deploy Preview for merch-site canceled.

Name Link
🔨 Latest commit 583dcbf
🔍 Latest deploy log https://app.netlify.com/sites/merch-site/deploys/65b4d768e0d3e500089dfa32

@@ -9,7 +9,9 @@
@csrf_exempt
def stripe_webhook(request) :
payload = request.body
sig_header = request.META['HTTP_STRIPE_SIGNATURE']
sig_header = request.META.get('HTTP_STRIPE_SIGNATURE', None)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arminpatel Why do we need this change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we can return a 400 error, otherwise it would return a 500

@Priyansh61 Priyansh61 merged commit ac84941 into bsoc-bitbyte:main Jan 27, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants