Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #206 : added product details page #211

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

ShashaankS
Copy link
Contributor

Overview

  1. This PR fixes or fixes part of [Feature Request]: Add "Product details" page #206 .
  2. This PR does the following: Added product detail page

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
  • The PR is made from a branch that's not called "main/master".

Proof that changes are correct

Screencast.from.07-17-2024.01.51.01.AM.webm

This is how the add to cart button behaves as of now
Screenshot from 2024-07-17 02-05-51

PR Pointers

  • If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL".
  • Never force push. If you do, your PR will be closed.

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for merch-site ready!

Name Link
🔨 Latest commit a06c2c7
🔍 Latest deploy log https://app.netlify.com/sites/merch-site/deploys/669ce23a95d6370008052ad7
😎 Deploy Preview https://deploy-preview-211--merch-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AkashPaloju
Copy link
Collaborator

AkashPaloju commented Jul 18, 2024

@ShashaankS Please show the "Share" button functionality.

@ShashaankS
Copy link
Contributor Author

ShashaankS commented Jul 18, 2024

@ShashaankS Please show the "Share" button functionality.

Screencast.from.07-18-2024.08.16.24.PM.webm

@AkashPaloju On pressing share button, link is copied to clipboard with a success toast.

@ShashaankS
Copy link
Contributor Author

Screencast.from.07-20-2024.12.22.04.PM.webm

@Kushdapush @AkashPaloju Photo gallery functionality

<script setup>
import { ref, onMounted } from "vue";
import { useRoute } from "vue-router";
import { useCartStore } from "../../store/index.js"; // Assuming your store is located here
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this comment

const cartStore = useCartStore();
const router = useRouter();
const error = ref();
// const colorList = ["#32a852", "blue", "green"];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this too

"./layouts/default.vue",
"./Frontend/**/*.{js,ts,jsx,tsx}",
],
// ...
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too

@AkashPaloju AkashPaloju merged commit 20d1a6a into bsoc-bitbyte:main Jul 22, 2024
5 of 6 checks passed
@AkashPaloju AkashPaloju linked an issue Jul 22, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add "Product details" page
3 participants