feat: add typescript declaration file #29
Conversation
rickstaa
force-pushed
the
add_ts_declaration_files
branch
from
f2d4e93 to
a895439
Compare
rickstaa
force-pushed
the
add_ts_declaration_files
branch
from
a895439 to
d824cb0
Compare
|
@bsonntag I'm currently trying to clean up my project dependencies and noticed that this pull request has not yet been merged. Are there things that have to be changed before this can be merged? |
|
@rickstaa The other way is to make a pull request to https://github.com/DefinitelyTyped/DefinitelyTyped. I can do it if you want. |
| settings: { | ||
| react: { | ||
| version: '999.999.999', | ||
| }, | ||
| }, |
There was a problem hiding this comment.
@ChocolateLoverRaj Thanks a lot for looking at this pull request and for offering to merge it into https://github.com/DefinitelyTyped/DefinitelyTyped.
Why this?
Good catch! Sorry, I should have added a comment for that hotfix. I added it to get rid of the following warning:
Warning: React version was set to "detect" in eslint-plugin-react settings, but the "react" package is not installed. Assuming latest React version for linting.This warning is caused since @bsonntag uses eslint-plugin-react in his @bsonntag/eslint-config eslint config package and this is a non react package:
stop-media-stream/package.json
Line 28 in 934ebf4
An explanation can be found in this issue. It should not be needed if you are planning to merge the type definitions into https://github.com/DefinitelyTyped/DefinitelyTyped. 👍🏻
This pull request adds typescript type definitions.