Skip to content

Fix tests and build warnings #344

Fix tests and build warnings

Fix tests and build warnings #344

Triggered via push November 7, 2024 12:01
Status Success
Total duration 2m 19s
Artifacts

desktop.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

20 warnings
build: BTCPayApp.Core/Helpers/SystemTextJsonMergeExtensions.cs#L78
Cannot convert null literal to non-nullable reference type.
build: BTCPayApp.Core/Helpers/ObservableConcurrentDictionary.cs#L14
The type 'TKey' cannot be used as type parameter 'TKey' in the generic type or method 'ConcurrentDictionary<TKey, TValue>'. Nullability of type argument 'TKey' doesn't match 'notnull' constraint.
build: BTCPayApp.Core/Migrations/20240726135741_triggers.cs#L9
The type name 'triggers' only contains lower-cased ascii characters. Such names may become reserved for the language.
build: BTCPayApp.Core/Migrations/20240726135741_triggers.Designer.cs#L15
The type name 'triggers' only contains lower-cased ascii characters. Such names may become reserved for the language.
build: BTCPayApp.Core/Migrations/20240805085647_checkpoitnchannels.cs#L8
The type name 'checkpoitnchannels' only contains lower-cased ascii characters. Such names may become reserved for the language.
build: BTCPayApp.Core/Migrations/20240805085647_checkpoitnchannels.Designer.cs#L15
The type name 'checkpoitnchannels' only contains lower-cased ascii characters. Such names may become reserved for the language.
build: BTCPayApp.Core/Migrations/20240820073346_channelpimp.cs#L8
The type name 'channelpimp' only contains lower-cased ascii characters. Such names may become reserved for the language.
build: BTCPayApp.Core/Migrations/20240820073346_channelpimp.Designer.cs#L15
The type name 'channelpimp' only contains lower-cased ascii characters. Such names may become reserved for the language.
build: BTCPayApp.Core/Helpers/ObservableConcurrentDictionary.cs#L112
Nullability of reference types in type of 'event NotifyCollectionChangedEventHandler ObservableConcurrentDictionary<TKey, TValue>.CollectionChanged' doesn't match implicitly implemented member 'event NotifyCollectionChangedEventHandler? INotifyCollectionChanged.CollectionChanged'.
build: BTCPayApp.Core/Helpers/ObservableConcurrentDictionary.cs#L115
Nullability of reference types in type of 'event PropertyChangedEventHandler ObservableConcurrentDictionary<TKey, TValue>.PropertyChanged' doesn't match implicitly implemented member 'event PropertyChangedEventHandler? INotifyPropertyChanged.PropertyChanged'.
build: submodules/btcpayserver/BTCPayServer/App/API/ResultOverrideFilter.cs#L8
'ResultOverrideFilter.OnResultExecuted(ResultExecutedContext)' hides inherited member 'ResultFilterAttribute.OnResultExecuted(ResultExecutedContext)'. To make the current member override that implementation, add the override keyword. Otherwise add the new keyword.
build: submodules/btcpayserver/BTCPayServer/App/API/ResultOverrideFilter.cs#L12
'ResultOverrideFilter.OnResultExecuting(ResultExecutingContext)' hides inherited member 'ResultFilterAttribute.OnResultExecuting(ResultExecutingContext)'. To make the current member override that implementation, add the override keyword. Otherwise add the new keyword.
build: submodules/btcpayserver/BTCPayServer/App/API/ProtobufInputFormatter.cs#L17
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build: submodules/btcpayserver/BTCPayServer/App/Exts.cs#L19
Possible null reference return.
build: submodules/btcpayserver/BTCPayServer/App/BTCPayAppHub.cs#L180
Possible null reference argument for parameter 'hash' in 'Task<BlockHeader> BTCPayAppHub.GetBlockHeader(uint256 hash)'.
build: submodules/btcpayserver/BTCPayServer/App/Exts.cs#L42
Possible null reference return.
build: submodules/btcpayserver/BTCPayServer/App/Exts.cs#L44
Possible null reference argument for parameter 'value' in 'long Extensions.Value<long>(IEnumerable<JToken> value)'.
build: submodules/btcpayserver/BTCPayServer/App/Exts.cs#L46
Possible null reference return.
build: submodules/btcpayserver/BTCPayServer/App/Exts.cs#L52
Possible null reference argument for parameter 'value' in 'int Extensions.Value<int>(IEnumerable<JToken> value)'.
build: submodules/btcpayserver/BTCPayServer/App/Exts.cs#L53
Possible null reference argument for parameter 'value' in 'long Extensions.Value<long>(IEnumerable<JToken> value)'.