Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Configuration] Ensure ConfigureController works on PS 8.0 #140

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

BitcoinMitchell
Copy link
Collaborator

@BitcoinMitchell BitcoinMitchell commented Jul 4, 2024

Description

Adds a simple check to ensure we either use the new $this->getConfiguration() or the old $this->configuration. We can remove this check as soon as we require PS 8.1 as minimum.

Having said this, we should probably stop supporting PS 8.0 soon, since there are a lot of security issues in those version. In fact, Roave/SecurityAdvisories restricts everything below PS 8.1.6.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change which improves the codebase)

How Has This Been Tested?

Start a Docker with the bitnami/prestashop:8.0.4 image, upload the ZIP, configure the plugin.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have checked my code and corrected any misspellings

Test zip (v6.1.5): btcpay.zip

@BitcoinMitchell BitcoinMitchell self-assigned this Jul 4, 2024
Copy link
Contributor

@ndeet ndeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, LGTM. 🥳

Guess you left the 8.0.4 version in the docker compose for testing purposes. Can be changed to latest 8.1.x at a later point.

@ndeet
Copy link
Contributor

ndeet commented Jul 5, 2024

About stopping support for 8.0.x, agree if they don't do any security fixes anymore.

@BitcoinMitchell
Copy link
Collaborator Author

Guess you left the 8.0.4 version in the docker compose for testing purposes. Can be changed to latest 8.1.x at a later point.

I left the version in the docker-compose on purpose, so I can make sure the plugin still works on that version.


About stopping support for 8.0.x, agree if they don't do any security fixes anymore.

Think I will make a new feature release that just bumps the minimum Prestashop version.

@BitcoinMitchell BitcoinMitchell merged commit 86efeb7 into 6.x Jul 5, 2024
4 checks passed
@BitcoinMitchell BitcoinMitchell deleted the fix-configuration branch July 5, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: undefined method named getConfiguration()
2 participants