[Configuration] Ensure ConfigureController works on PS 8.0 #140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a simple check to ensure we either use the new
$this->getConfiguration()
or the old$this->configuration
. We can remove this check as soon as we require PS 8.1 as minimum.Having said this, we should probably stop supporting PS 8.0 soon, since there are a lot of security issues in those version. In fact,
Roave/SecurityAdvisories
restricts everything below PS 8.1.6.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Start a Docker with the
bitnami/prestashop:8.0.4
image, upload the ZIP, configure the plugin.Checklist:
Test zip (v6.1.5): btcpay.zip