Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commits for module validation #98

Merged
merged 6 commits into from
Feb 28, 2024

Conversation

BitcoinMitchell
Copy link
Collaborator

@BitcoinMitchell BitcoinMitchell commented Feb 19, 2024

Description

This PR prepares the module to be validated by the PrestaShop team.

These changes are based on the Prestashop Validation Checklist.

Type of change

  • Refactor (non-breaking change which improves the codebase)

How Has This Been Tested?

Module was build and tested on a local Prestashop store.

Test Configuration

  • BTCPay Server version: 1.12.5
  • PrestaShop version: 8.1.3
  • PHP version: 8.1.27

Test zip: v6.1.2

@BitcoinMitchell BitcoinMitchell force-pushed the prepare-for-module-verification branch 2 times, most recently from c72488e to 6151592 Compare February 21, 2024 22:32
@BitcoinMitchell BitcoinMitchell force-pushed the prepare-for-module-verification branch 2 times, most recently from f737de0 to 117daaf Compare February 23, 2024 09:20
@BitcoinMitchell BitcoinMitchell changed the title Prepare for module validation Initial commits for module validation Feb 28, 2024
Copy link
Contributor

@ndeet ndeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only read the code but did not test locally. Those constant checks are common but those index.php in the subfolders with header('Location: ../') was new to me, normally it is just an empty index.php but for sure there are "reasons" :D

@BitcoinMitchell BitcoinMitchell merged commit 7e43360 into 6.x Feb 28, 2024
4 checks passed
@BitcoinMitchell BitcoinMitchell deleted the prepare-for-module-verification branch February 28, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants