Add an --idle_timer test #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for adding! I'm not sure what the test here does (does it exercise any functionality?). If it only runs the server for 1s, I don't think it'll fail. You need to http query it for a blob (even the empty blob works), which will cause infinite recursion/stack overflow. |
mostynb
force-pushed
the
idle_timer_test
branch
from
482d6c3 to
b81f0ea
Compare
|
Updated with a fix, it fails now as expected. |
This is expected to fail, until buchgr#727 lands.
mostynb
force-pushed
the
idle_timer_test
branch
from
b81f0ea to
59a1337
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is expected to fail, until #727 lands.