Remove gogo support #340
Merged
Remove gogo support #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: michael.wozniak <[email protected]>
Signed-off-by: michael.wozniak <[email protected]>
Signed-off-by: michael.wozniak <[email protected]>
dir Signed-off-by: michael.wozniak <[email protected]>
Signed-off-by: michael.wozniak <[email protected]>
Signed-off-by: michael.wozniak <[email protected]>
|
I'm fine dropping gogo since I found it difficult to maintain personally. I am not aware of other users of protoc-gen-validate gogo feature. |
|
SGTM. @wozz can you merge master? |
|
Sorry, looks like merging #343 introduced a few more conflicts. Once more, please! |
|
No, please keep them separate. It looks like there are still some |
|
Thanks, I had the order reversed in my head. I'll go ahead and take a look over there then |
Signed-off-by: michael.wozniak <[email protected]>
Signed-off-by: michael.wozniak <[email protected]>
akonradi
approved these changes
Jun 9, 2020
|
Thanks! |
rvolosatovs
added a commit
to TheThingsIndustries/protoc-gen-validate
that referenced
this pull request
Aug 7, 2020
This reverts commit c7c8be4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting up #338 into smaller changes. This change removes support for gogo.
The main reason to drop support is so that protoc-gen-validate can be updated to use the new protobuf API, which gogo does not support. Additionally, it seems up in the air if gogo will continue to be maintained: gogo/protobuf#691
If support is later added for gogo and maintenance picks back up, gogo support can be added back to protoc-gen-validate.
These changes are built on top of #339