Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🇬🇧 Show 'en' as language for english models #306

Merged
merged 1 commit into from
Jul 26, 2023
Merged

🇬🇧 Show 'en' as language for english models #306

merged 1 commit into from
Jul 26, 2023

Conversation

phlmn
Copy link
Member

@phlmn phlmn commented Jul 25, 2023

fixes #297

@phlmn phlmn requested a review from anuejn July 25, 2023 22:39
@phlmn phlmn enabled auto-merge (rebase) July 25, 2023 22:41
@anuejn anuejn force-pushed the phlmn/show-en-models-as-en branch from 7f68508 to 2657d44 Compare July 25, 2023 23:14
@phlmn phlmn disabled auto-merge July 25, 2023 23:49
@phlmn phlmn enabled auto-merge (rebase) July 25, 2023 23:50
@phlmn phlmn requested a review from anuejn July 25, 2023 23:51
anuejn
anuejn approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@anuejn anuejn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phlmn phlmn disabled auto-merge July 25, 2023 23:52
@phlmn phlmn enabled auto-merge (rebase) July 25, 2023 23:53
@rroohhh rroohhh disabled auto-merge July 26, 2023 00:51
@rroohhh rroohhh enabled auto-merge (rebase) July 26, 2023 00:51
auto-merge was automatically disabled July 26, 2023 00:55

Merge queue setting changed

@phlmn phlmn added this pull request to the merge queue Jul 26, 2023
Merged via the queue into main with commit 5601e1b Jul 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuejn anuejn anuejn approved these changes

@rroohhh rroohhh rroohhh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

correctly display language of _en models as english
3 participants
@phlmn @rroohhh @anuejn