Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Only render children if in view #327

Merged
merged 1 commit into from
Aug 6, 2023
Merged

⚡️ Only render children if in view #327

merged 1 commit into from
Aug 6, 2023

Conversation

pajowu
Copy link
Member

@pajowu pajowu commented Aug 3, 2023

Rendering just the text (so that searching and scrolling still kindof work) leads to better initial loading performance

Rendering just the text (so that searching and scrolling still kindof work) leads to better initial loading performance
@pajowu pajowu changed the title Pajowus Performance Experiments ⚡️ Only render children if in view Aug 6, 2023
@pajowu pajowu requested review from phlmn, rroohhh and anuejn August 6, 2023 12:17
@pajowu pajowu marked this pull request as ready for review August 6, 2023 12:17
Copy link
Member

@anuejn anuejn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very smart Idea & saves us a lot of dom elements :))

@pajowu pajowu added this pull request to the merge queue Aug 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 6, 2023
@anuejn anuejn added this pull request to the merge queue Aug 6, 2023
Merged via the queue into main with commit a243c39 Aug 6, 2023
2 checks passed
@anuejn anuejn deleted the pajowu/performance branch August 6, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants