This repository has been archived by the owner on Jan 7, 2021. It is now read-only.
tests: update lab and have tests return a promise #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like joi only supports Node 8+. We have to do the same or downgrade joi. The spread operator is causing a test failure in older versions of Node. |
|
When do you think this could be merged? |
c4milo
approved these changes
Jul 19, 2018
|
What is missing for this PR to be merged ? |
c4milo
approved these changes
Aug 12, 2018
|
It needs a rebase |
|
@scragg0x the version of lab used in the package-lock is 15.4.4, could you update it at least to 15.5.0 in order to avoid warning about memory leaks with node 10 ? |
|
Fixed in #166 |
|
i am open to merge any pull request. I fixed it an named it as p3x-xml2json and it works with Nodejs 12. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.