-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logcat messages to metadata #1905
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from lemnik
September 20, 2023 13:56
Android notifier sizes
Generated by 🚫 Danger |
lemnik
requested changes
Sep 25, 2023
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/TombstoneParser.kt
Outdated
Show resolved
Hide resolved
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/TombstoneParser.kt
Outdated
Show resolved
Hide resolved
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/TombstoneParser.kt
Outdated
Show resolved
Hide resolved
ghost
force-pushed
the
PLAT-10707/add-logcat-messages-to-metadata
branch
from
September 25, 2023 14:15
cc78afd
to
23c5062
Compare
ghost
requested a review
from lemnik
September 25, 2023 14:16
lemnik
reviewed
Sep 28, 2023
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/BugsnagExitInfoPlugin.kt
Outdated
Show resolved
Hide resolved
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/TombstoneParser.kt
Outdated
Show resolved
Hide resolved
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/TombstoneParser.kt
Outdated
Show resolved
Hide resolved
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/TombstoneParser.kt
Outdated
Show resolved
Hide resolved
ghost
force-pushed
the
PLAT-10707/add-logcat-messages-to-metadata
branch
from
September 28, 2023 14:41
217fc45
to
515043e
Compare
ghost
requested a review
from lemnik
September 28, 2023 15:00
lemnik
reviewed
Sep 29, 2023
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/ExitInfoCallback.kt
Outdated
Show resolved
Hide resolved
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/TombstoneEventEnhancer.kt
Outdated
Show resolved
Hide resolved
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/TombstoneParser.kt
Outdated
Show resolved
Hide resolved
ghost
force-pushed
the
PLAT-10707/add-logcat-messages-to-metadata
branch
3 times, most recently
from
September 29, 2023 09:02
1365bd1
to
940b138
Compare
ghost
requested a review
from lemnik
September 29, 2023 09:02
lemnik
reviewed
Sep 29, 2023
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/ExitInfoCallback.kt
Outdated
Show resolved
Hide resolved
ghost
force-pushed
the
PLAT-10707/add-logcat-messages-to-metadata
branch
from
September 29, 2023 10:11
940b138
to
576afb3
Compare
ghost
requested a review
from lemnik
September 29, 2023 10:11
ghost
force-pushed
the
PLAT-10707/add-logcat-messages-to-metadata
branch
from
September 29, 2023 10:34
576afb3
to
9daf4ef
Compare
lemnik
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Pending CI
ghost
deleted the
PLAT-10707/add-logcat-messages-to-metadata
branch
September 29, 2023 13:45
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
An option to add log message from Tombstone file to Bugsnag
metadata
.Changeset
Add an option in Bugsnag ExitInfo Plugin to parse the log message from Tombstone file and added it to metadata
Testing
Introduce new unit test and manual test on example app