Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logcat messages to metadata #1905

Merged
2 commits merged into from
Sep 29, 2023

Conversation

ghost
Copy link

@ghost ghost commented Sep 20, 2023

Goal

An option to add log message from Tombstone file to Bugsnag metadata.

Changeset

Add an option in Bugsnag ExitInfo Plugin to parse the log message from Tombstone file and added it to metadata

Testing

Introduce new unit test and manual test on example app

@ghost ghost requested a review from lemnik September 20, 2023 13:56
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Sep 20, 2023

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1840.53 1670.11
arm64_v8a 622.99 450.96
armeabi_v7a 557.46 385.43
x86 700.79 524.67
x86_64 668.03 496.0

Generated by 🚫 Danger

@ghost ghost force-pushed the PLAT-10707/add-logcat-messages-to-metadata branch from cc78afd to 23c5062 Compare September 25, 2023 14:15
@ghost ghost requested a review from lemnik September 25, 2023 14:16
@ghost ghost force-pushed the PLAT-10707/add-logcat-messages-to-metadata branch from 217fc45 to 515043e Compare September 28, 2023 14:41
@ghost ghost requested a review from lemnik September 28, 2023 15:00
@ghost ghost force-pushed the PLAT-10707/add-logcat-messages-to-metadata branch 3 times, most recently from 1365bd1 to 940b138 Compare September 29, 2023 09:02
@ghost ghost requested a review from lemnik September 29, 2023 09:02
@ghost ghost force-pushed the PLAT-10707/add-logcat-messages-to-metadata branch from 940b138 to 576afb3 Compare September 29, 2023 10:11
@ghost ghost requested a review from lemnik September 29, 2023 10:11
@ghost ghost force-pushed the PLAT-10707/add-logcat-messages-to-metadata branch from 576afb3 to 9daf4ef Compare September 29, 2023 10:34
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Pending CI

@ghost ghost merged commit dbe7d40 into integration/v6 Sep 29, 2023
@ghost ghost deleted the PLAT-10707/add-logcat-messages-to-metadata branch September 29, 2023 13:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants