Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Warning log when persisted user file not loaded #1906

Conversation

ghost
Copy link

@ghost ghost commented Sep 27, 2023

Goal

Warning log would not show when persisted user file is not loaded

Changeset

Add persisted user file exist checks and config persist user check in when loading user

Testing

Manual test and refactor existing tests

@ghost ghost requested a review from lemnik September 27, 2023 17:39
@bugsnagbot
Copy link
Collaborator

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1866.07 1697.81
arm64_v8a 627.08 459.15
armeabi_v7a 565.65 393.62
x86 704.89 532.86
x86_64 672.13 504.19

Generated by 🚫 Danger

@ghost ghost changed the title No Warning log when persisted user file not loaded Remove Warning log when persisted user file not loaded Sep 28, 2023
@ghost ghost closed this Sep 28, 2023
@ghost ghost deleted the PLAT8093/warning-always-logged-when-persisted-user-file-not-loaded branch September 28, 2023 10:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants