Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Warning log when persisted user file not loaded #1908

Conversation

ghost
Copy link

@ghost ghost commented Sep 28, 2023

Goal

Warning log would not show when persisted user file is not loaded

Changeset

Add persisted user file exist checks and config persist user check in when loading user

Testing

Manual test and refactor existing tests

@ghost ghost requested a review from lemnik September 28, 2023 10:30
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Sep 28, 2023

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1866.05 1697.8
arm64_v8a 627.08 459.15
armeabi_v7a 565.65 393.62
x86 704.89 532.86
x86_64 672.13 504.19

Generated by 🚫 Danger

@ghost ghost force-pushed the PLAT-8093/warning-always-logged-when-persisted-user-file-not-loaded branch from a23352c to 4aa0f44 Compare September 29, 2023 13:55
@ghost ghost force-pushed the PLAT-8093/warning-always-logged-when-persisted-user-file-not-loaded branch from 4aa0f44 to 9bee2dc Compare October 3, 2023 13:33
@ghost ghost requested a review from lemnik October 3, 2023 13:33
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 6ec18c2 into integration/v6 Oct 4, 2023
2 checks passed
@ghost ghost deleted the PLAT-8093/warning-always-logged-when-persisted-user-file-not-loaded branch October 4, 2023 08:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants