Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session payload versions #1911

Merged

Conversation

ghost
Copy link

@ghost ghost commented Oct 3, 2023

Bug

V3 session payload is delivered as legacy payload

Changeset

V3 session payload will be processed and be delivered as non legacy payload

Testing

Existing unit tests

@ghost ghost requested a review from lemnik October 3, 2023 09:40
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Oct 3, 2023

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1922.59 1696.89
arm64_v8a 680.33 459.15
armeabi_v7a 618.9 393.62
x86 758.14 532.86
x86_64 725.38 504.19

Generated by 🚫 Danger

@ghost ghost force-pushed the PLAT-10965/v3-session-payloads-being-picked-up-as-v1-payloads branch from 0bc747a to 1863c1e Compare October 3, 2023 13:29
@ghost ghost requested a review from lemnik October 3, 2023 13:30
@ghost ghost force-pushed the PLAT-10965/v3-session-payloads-being-picked-up-as-v1-payloads branch 2 times, most recently from 51ca589 to d6eade9 Compare October 10, 2023 08:36
@ghost ghost requested a review from lemnik October 10, 2023 08:38
@ghost ghost force-pushed the PLAT-10965/v3-session-payloads-being-picked-up-as-v1-payloads branch from d6eade9 to e0d074e Compare October 10, 2023 09:59
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 7640f5e into next Oct 10, 2023
6 checks passed
@ghost ghost deleted the PLAT-10965/v3-session-payloads-being-picked-up-as-v1-payloads branch October 10, 2023 15:16
@ghost ghost mentioned this pull request Oct 11, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants