-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update IfcEnergyConversionDevice.md #873
Conversation
Hold on, these 8 entities are still deprecated (by IFC 4). Don't they miss the deprecation label? See #874 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just rephrase? Same meaning, just a bit more precise.
{ .change-ifc2x4}
IFC4 CHANGE This entity shall not be instantiated and shall be treated as if it were deprecated. It will become ABSTRACT in a future major release, and its subtypes should be used instead.
agree to the rephrasing proposal. |
It should be treated as abstract, not as deprecated. How about:
|
lets keep the keyword "deprecation" IFC4 DEPRECATION This entity shall be treated as abstract and not be instantiated; its subtypes should be used instead. It will become ABSTRACT in a future major release. i.e. adding a standardized deprecation tag, that is searchable and could be used to generate a list of all active deprecations as part of the change log. |
According to my knowledge there isn't a well established term for deprecation only for concrete usage as in a transition from a concrete to an abstract class. I would vote for not marking this as deprecated. |
remove ABSTRACT annotation. Read more in #871