Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IfcEnergyConversionDevice.md #873

Closed
wants to merge 2 commits into from
Closed

Update IfcEnergyConversionDevice.md #873

wants to merge 2 commits into from

Conversation

atomczak
Copy link
Contributor

remove ABSTRACT annotation. Read more in #871

remove ABSTRACT annotation. Read more in #871
@evandroAlfieri
Copy link
Contributor

Hold on, these 8 entities are still deprecated (by IFC 4). Don't they miss the deprecation label? See #874

@atomczak
Copy link
Contributor Author

are they deprecated? It says "deprecated for instantiation and will become ABSTRACT". But as @TLiebich said in #871, they were not even made abstract after all.

Copy link
Contributor

@evandroAlfieri evandroAlfieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just rephrase? Same meaning, just a bit more precise.

{ .change-ifc2x4}

IFC4 CHANGE This entity shall not be instantiated and shall be treated as if it were deprecated. It will become ABSTRACT in a future major release, and its subtypes should be used instead.

@TLiebich
Copy link
Collaborator

agree to the rephrasing proposal.

@atomczak
Copy link
Contributor Author

It should be treated as abstract, not as deprecated. How about:

IFC4 CHANGE This entity shall be treated as abstract and not be instantiated; its subtypes should be used instead. It will become ABSTRACT in a future major release.

@TLiebich
Copy link
Collaborator

lets keep the keyword "deprecation"
also for collecting all active deprecations into a single list

IFC4 DEPRECATION This entity shall be treated as abstract and not be instantiated; its subtypes should be used instead. It will become ABSTRACT in a future major release.

i.e. adding a standardized deprecation tag, that is searchable and could be used to generate a list of all active deprecations as part of the change log.

@atomczak
Copy link
Contributor Author

"IFC DEPRECATION" would result in this tag:
image
which to me would imply this IfcEnergyConversionDevice is deprecated, but it isn't.

I give up; let's keep the tags as they currently are.

@atomczak atomczak closed this Jul 15, 2024
@aothms
Copy link
Collaborator

aothms commented Jul 17, 2024

According to my knowledge there isn't a well established term for deprecation only for concrete usage as in a transition from a concrete to an abstract class. I would vote for not marking this as deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants