-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update IFC.xml #26
base: main
Are you sure you want to change the base?
Update IFC.xml #26
Conversation
All changes from the IFC Tunnel project up until now.
Thanks @larswik on first inspection I found the following minor issues. Hope you can resolve them: IfcBorehole has 2 generalizations:
There are attributes without an order tag apparently:
IfcArchElementTypeEnum is an empty enumeration. I though the code was able to deal with this and add userdefined/notdefined automatically, but appears to be not the case.
|
Which might be my error actually if you didn't touch it. It's fine. Attributes without an order tag go last, which is also where it should be in the schema. |
Hi Thomas and thanks,
I can take a look at these things (including the attribute ordering while I am in there) tomorrow and update the pr.
BR
Lars
Skickat från Outlook för Android<https://aka.ms/AAb9ysg>
…________________________________
From: Thomas Krijnen ***@***.***>
Sent: Wednesday, January 18, 2023 11:35:26 AM
To: buildingSMART/IFC4.4.x-development ***@***.***>
Cc: Lars Wikström ***@***.***>; Mention ***@***.***>
Subject: Re: [buildingSMART/IFC4.4.x-development] Update IFC.xml (PR #26)
There are attributes without an order tag apparently:
WARNING:root:No attribute order on IfcWellKnownText.CoordinateReferenceSystem
Which might be my error actually if you didn't touch it. It's fine. Attributes without an order tag go last, which is also where it should be in the schema.
—
Reply to this email directly, view it on GitHub<#26 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGCTEZFP4NYW64IZQNPXGPDWS7BO5ANCNFSM6AAAAAAT4Q6OSE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Removed the generalization IfcBorehole=>IfcGeotechnicalAssembly. - Generalization (new from IFC Tunnel) IfcBorehole=>IfcGeoScienceElement remains Added ExpressOrdering for IfcWellKnownText (WellKnownText + CoordinateReferenceSystem) Added enums USERDEFINED and NOTDEFINED to IfcArchElementTypeEnum
Fixed the association between IfcRelAssociates and IfcDatasetReference (mixed up source and target roles). Added attribute IfcDatasetReference.Description : IfcText
Sorry, these errors are triggered at the parse stage of the resulting exp and the parser halts at the first error. We had a pt-class <packagedElement xmi:type="uml:Class" xmi:id="EAID_DA826A73_37EF_4c25_BCB1_516B1B650DF4" name="IfcTunnelPartTypeEnum.RINGSECTION/ROUND" visibility="public"/> The uml enum item itself was simply classed RINGSECTION, since I had the changes locally a committed them (and then accidentally pushed to your fork...) |
All changes from the IFC Tunnel project up until now.