Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IFC.xml #26

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

larswik
Copy link
Collaborator

@larswik larswik commented Jan 16, 2023

All changes from the IFC Tunnel project up until now.

All changes from the IFC Tunnel project up until now.
@aothms
Copy link
Collaborator

aothms commented Jan 18, 2023

Thanks @larswik on first inspection I found the following minor issues. Hope you can resolve them:

IfcBorehole has 2 generalizations:

					<packagedElement xmi:type="uml:Class" xmi:id="EAID_CC98D225_794C_1B19_E053_5801400A16D7" name="IfcBorehole" visibility="public">
						<ownedAttribute xmi:type="uml:Property" xmi:id="EAID_83003F24_F3ED_42ce_ADD9_7D7E40C09302" name="PredefinedType" visibility="public" isStatic="false" isReadOnly="false" isDerived="false" isOrdered="false" isUnique="true" isDerivedUnion="false">
							<type xmi:idref="EAID_C015424E_5710_4725_AA80_84F7F49C89DD"/>
							<lowerValue xmi:type="uml:LiteralInteger" xmi:id="EAID_LI010653_F3ED_42ce_ADD9_7D7E40C09302" value="1"/>
							<upperValue xmi:type="uml:LiteralInteger" xmi:id="EAID_LI010654_F3ED_42ce_ADD9_7D7E40C09302" value="1"/>
						</ownedAttribute>
						<generalization xmi:type="uml:Generalization" xmi:id="EAID_CC98D225_88FF_1B19_E053_5801400A16D7" general="EAID_CC98D225_796C_1B19_E053_5801400A16D7"/>
						<generalization xmi:type="uml:Generalization" xmi:id="EAID_D5D0E011_24DA_4696_BFC9_D8739A02E73B" general="EAID_91095E51_08E0_4d42_982E_DDFB9C7FF23E"/>
					</packagedElement>

There are attributes without an order tag apparently:

WARNING:root:No attribute order on IfcWellKnownText.CoordinateReferenceSystem

IfcArchElementTypeEnum is an empty enumeration. I though the code was able to deal with this and add userdefined/notdefined automatically, but appears to be not the case.

				<packagedElement xmi:type="uml:Enumeration" xmi:id="EAID_27E8865A_34F8_4f8a_9A44_3C94A9A71C7F" name="IfcArchElementTypeEnum" visibility="public"/>

@aothms
Copy link
Collaborator

aothms commented Jan 18, 2023

There are attributes without an order tag apparently:

WARNING:root:No attribute order on IfcWellKnownText.CoordinateReferenceSystem

Which might be my error actually if you didn't touch it. It's fine. Attributes without an order tag go last, which is also where it should be in the schema.

@larswik
Copy link
Collaborator Author

larswik commented Jan 18, 2023 via email

larswik and others added 4 commits January 19, 2023 09:20
Removed the generalization IfcBorehole=>IfcGeotechnicalAssembly.
- Generalization (new from IFC Tunnel) IfcBorehole=>IfcGeoScienceElement remains
Added ExpressOrdering for IfcWellKnownText (WellKnownText + CoordinateReferenceSystem)
Added enums USERDEFINED and NOTDEFINED to IfcArchElementTypeEnum
Fixed the association between IfcRelAssociates and IfcDatasetReference (mixed up source and target roles).
Added attribute IfcDatasetReference.Description : IfcText
@aothms
Copy link
Collaborator

aothms commented Jan 20, 2023

Sorry, these errors are triggered at the parse stage of the resulting exp and the parser halts at the first error.

We had a pt-class RINGSECTION/ROUND which is not a valid name for an express enum literal.

<packagedElement xmi:type="uml:Class" xmi:id="EAID_DA826A73_37EF_4c25_BCB1_516B1B650DF4" name="IfcTunnelPartTypeEnum.RINGSECTION/ROUND" visibility="public"/>

The uml enum item itself was simply classed RINGSECTION, since I had the changes locally a committed them (and then accidentally pushed to your fork...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants