Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IVS-137 ALB012 Vertical Segment Radius of Curvature #300

Open
wants to merge 22 commits into
base: development
Choose a base branch
from

Commits on Sep 24, 2024

  1. add ALB011 unit test files

    civilx64 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    1d2c578 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. feat/first commit of ALB011

    fg55b committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    9bd31c8 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. feat/added scenarios and steps

    Scenarios for validating the horizontal continuity were added. Those scenarios should be implemented in another rule, but were maintained in the commit to be evaluated, and should be altered after
    fg55b committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    bc9c3e8 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Merge branch 'development' of https://github.com/buildingSMART/ifc-gh…

    …erkin-rules into IVS-137-ALB011-IfcAlignmentVerticalSegment.RadiusOfCurvature
    civilx64 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    2e49010 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. feat/added precision tolerance to the comparison

    It was created a function of comparison that considers the instance context precision tolerance. This function was added in the 'then' step that compares an attributes to an expression.
    fg55b committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    fc93553 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b89ae45 View commit details
    Browse the repository at this point in the history
  3. rename ALB011 to ALB012

    ALB010 is already in use.
    Renaming this feature will allow for a new rule ALB011 to check RadiusOfCurvature
    for the horizontal layout.
    
    (IVS-137)
    civilx64 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    9969602 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Merge branch 'development' into IVS-137-ALB012-IfcAlignmentVerticalSe…

    …gment.RadiusOfCurvature
    civilx64 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    7670846 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Merge branch 'IVS-137-ALB011-IfcAlignmentVerticalSegment.RadiusOfCurv…

    …ature' of https://github.com/fg55b/ifc-gherkin-rules into IVS-137-ALB012-IfcAlignmentVerticalSegment.RadiusOfCurvature
    civilx64 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    50ace43 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. rename ALB011 to ALB012

    (IVS-143)
    civilx64 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    7f21949 View commit details
    Browse the repository at this point in the history
  2. finalize ALB012 feature file and unit tests

    ALB012 focuses solely on 'RadiusOfCurvature' design parameter and includes a scenario that fixes #241.
    
    (IVS-137)
    civilx64 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    29922bd View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Update feature file per review comments

    Co-authored-by: Thomas Krijnen <[email protected]>
    civilx64 and aothms authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    f5f6237 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. (WIP) addresses most of the ALB012 review comments

    - adds a Given statement for proper entity type of DesignParameters
    - adds `na` unit test file to confirm this new Given statement
    - adds `na` unit test file to confirm rule is not activated for alignment with horizontal layout only
    
    (IVS-137)
    civilx64 committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    3b6122a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    515cc49 View commit details
    Browse the repository at this point in the history
  3. add unit test file that raises ZeroDivisionError

    (IVS-137)
    civilx64 committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    42959f2 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Configuration menu
    Copy the full SHA
    d477990 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Update wording

    Ghesselink authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    21a5c6f View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Merge branch 'IVS-181-Fix-Custom-Error-Handling' of https://github.co…

    …m/buildingSMART/ifc-gherkin-rules into IVS-137-ALB012-IfcAlignmentVerticalSegment.RadiusOfCurvature
    civilx64 committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    6a3c82f View commit details
    Browse the repository at this point in the history
  2. rename test file for ALB012

    The test file that raises an exception
    should start with 'fail'.
    
    (IVS-137)
    civilx64 committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    3de923b View commit details
    Browse the repository at this point in the history
  3. Merge branch 'development' into IVS-137-ALB012-IfcAlignmentVerticalSe…

    …gment.RadiusOfCurvature
    civilx64 authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    d4190bc View commit details
    Browse the repository at this point in the history
  4. avoid NoneTypeError when processing outcomes

    (IVS-137)
    civilx64 committed Oct 24, 2024
    1 Configuration menu
    Copy the full SHA
    c382fe7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f6fc490 View commit details
    Browse the repository at this point in the history