Als007 #78
Merged
Als007 #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…because IfcGradientCurve is a subtype of IfcCompositeCurve
Ghesselink
requested changes
Sep 20, 2023
There was a problem hiding this comment.
Looks good.
The rule appears to evaluate three conditions, each associated with a separate test file.
I apologize for the nitpicking. In the README.md is mentioned
Unit test files must follow this naming convention
Expected result-rule code-rule scenario-short_informative_description.ifc
The rule_code is not present. So for example 'pass-sectioned-solid-horizontal.ifc' becomes 'pass-als005-sectioned-solid-horizontal.ifc'
test/files/als005/fail-sectioned-solid-horizontal-wrong-identifier.ifc
Outdated
Show resolved
Hide resolved
test/files/als007/fail-sectioned-solid-horizontal-wrong-identifier.ifc
Outdated
Show resolved
Hide resolved
test/files/als007/fail-sectioned-solid-horizontal-wrong-item.ifc
Outdated
Show resolved
Hide resolved
test/files/als007/fail-sectioned-solid-horizontal-wrong-type.ifc
Outdated
Show resolved
Hide resolved
pjanck
suggested changes
Sep 22, 2023
Ghesselink
approved these changes
Sep 24, 2023
|
Everything appears addressed. Thanks all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only review commit 66b8b8e pelase