-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Als007 #78
Conversation
…because IfcGradientCurve is a subtype of IfcCompositeCurve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
The rule appears to evaluate three conditions, each associated with a separate test file.
I apologize for the nitpicking. In the README.md is mentioned
Unit test files must follow this naming convention
Expected result-rule code-rule scenario-short_informative_description.ifc
The rule_code is not present. So for example 'pass-sectioned-solid-horizontal.ifc' becomes 'pass-als005-sectioned-solid-horizontal.ifc'
test/files/als005/fail-sectioned-solid-horizontal-wrong-identifier.ifc
Outdated
Show resolved
Hide resolved
test/files/als007/fail-sectioned-solid-horizontal-wrong-identifier.ifc
Outdated
Show resolved
Hide resolved
test/files/als007/fail-sectioned-solid-horizontal-wrong-item.ifc
Outdated
Show resolved
Hide resolved
test/files/als007/fail-sectioned-solid-horizontal-wrong-type.ifc
Outdated
Show resolved
Hide resolved
Everything appears addressed. Thanks all. |
Only review commit 66b8b8e pelase