Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement list command for Cluster #355

Merged
merged 11 commits into from
Oct 10, 2024
Merged

Implement list command for Cluster #355

merged 11 commits into from
Oct 10, 2024

Conversation

mcncl
Copy link
Contributor

@mcncl mcncl commented Sep 11, 2024 •
edited
Loading

  • Adds a list command to clusters
  • Standardises the output of view and list so that the view is consistent
    • Output is a table similar to docker ls commands

CleanShot 2024-09-11 at 14 55 47

jradtilbrook
jradtilbrook reviewed Sep 11, 2024
View reviewed changes
internal/cluster/query.go Outdated Show resolved Hide resolved
internal/cluster/query.go Outdated Show resolved Hide resolved
@mcncl mcncl changed the base branch from 3.x to main October 7, 2024 00:52
lizrabuya
lizrabuya approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@lizrabuya lizrabuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcncl mcncl merged commit 93d4825 into main Oct 10, 2024
1 check passed
@mcncl mcncl deleted the SUP-2579/cluster_list branch October 10, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizrabuya lizrabuya lizrabuya approved these changes

@PriyaSudip PriyaSudip Awaiting requested review from PriyaSudip PriyaSudip is a code owner

@jradtilbrook jradtilbrook Awaiting requested review from jradtilbrook

@jykingston jykingston Awaiting requested review from jykingston jykingston is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcncl @jradtilbrook @lizrabuya