-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pipelines product 'Service Quotas' page #2774
Conversation
Preview URL: https://2774--bk-docs-preview.netlify.app |
2b1b7a1
to
016dbc3
Compare
2a42959
to
cc9963a
Compare
cc9963a
to
6578eb6
Compare
data/nav.yml
Outdated
@@ -391,6 +391,8 @@ | |||
- name: "Cluster queue metrics" | |||
path: "pipelines/cluster-queue-metrics" | |||
pill: "beta" | |||
- name: "Service Quotas" | |||
path: "pipelines/service-quotas" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I note you've got this under Pipelines, but a handful of the limits are not pipelines-specific. I wonder if we need a global page? or just limit what's on this one to pipelines ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we do need a global page. At the moment, our navigation has:
Are you envisioning a new nav link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably need guidance from @gilesgas on that, but the content on this page atm doesn't really fit under pipelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are the docs for setting up organisations, teams, permissions etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content on this page atm doesn't really fit under pipelines.
Yeah, you're right. It feels like we're missing a concept of a global/cross-product area
Where are the docs for setting up organisations, teams, permissions etc?
At the moment those pages sit under the Pipelines navigation link - https://buildkite.com/docs/team-management/permissions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, they're not 😅😅
pages/pipelines/service_quotas.md
Outdated
{ | ||
title: "Invitations per organization", | ||
description: "The maximum number of pending invitations for an organization", | ||
default_value: "20 invitations" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another general thought – how do we keep these values synced with what's in bk/bk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An assertion spec in bk/bk, with a link to this guide doc to update it if an engineer changes the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might be able to leverage some internal tooling options (e.g. https://github.com/danger/danger) to help us out here in the bk/bk side 👀
Hey @dabarrell and @mitchbne , Sorry it's taken me a while to revisit this PR, now that we have the new Platform area for the docs, I'm wondering if we could publish this work somewhere in here instead? If so, I can fix this up for you... |
In this PR we introduce a Service Quotas page for limits within the Pipelines product.