Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds platform environment variables related content from the spec #771

Merged

Conversation

hyounes4560
Copy link
Contributor

adds platform environment variables related content under the platform section

@hyounes4560 hyounes4560 requested a review from a team as a code owner October 7, 2024 00:54
@natalieparellano
Copy link
Member

We can avoid repeating ourselves by directing the platform operator to https://buildpacks.io/docs/for-buildpack-authors/how-to/write-buildpacks/specify-env/

We just need to point out that platform operators have final say on what the environment will look like (and direct them to the spec for further details like "default" behavior when none is specified)

Aidan will jump in with a realistic example

Signed-off-by: Hanan Younes <[email protected]>
@hyounes4560
Copy link
Contributor Author

updated, @AidanDelaney could you please take a look and add an example? Thanks


### Example

PLACEHOLDER
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Hanan Younes <[email protected]>
@AidanDelaney AidanDelaney merged commit e511194 into buildpacks:main Nov 4, 2024
3 of 4 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 4, 2024
* adds platform env var related content from the spec

Signed-off-by: Hanan Younes <[email protected]>

---------

Signed-off-by: Hanan Younes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants