Use the 'boolean' gem if available #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a fallback that allows for other gems defining them, only define Boolean and XmlContent if they're not already defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a fallback that allows for other gems defining them, only define
Boolean and XmlContent if they're not already defined.
Currently unhappymapper and the boolean gem are incompatible, because unhappymapper defines Boolean as a class, and the boolean gem defines it as a module.
This patch will load the boolean gem if available and fall back to defining Boolean locally, but only if Boolean is not already defined (I did the same for XmlContent just in case too), so if there are other gems that define these consts as something other than class, you can load them before unhappymapper and things will be happy.