This repository has been archived by the owner on Oct 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
Restructure on-boarding from Slack messages to website #301
Merged
alysivji
merged 11 commits into
busy-beaver-dev:master
from
alysivji:restructure-onboarding
Jul 26, 2020
Merged
Restructure on-boarding from Slack messages to website #301
alysivji
merged 11 commits into
busy-beaver-dev:master
from
alysivji:restructure-onboarding
Jul 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alysivji
commented
Jul 26, 2020
|
||
day_of_week = SelectField("Day to post", choices=WEEKDAYS, default="Monday") | ||
post_time = TimeField("Time to post", validators=[DataRequired()]) | ||
post_timezone = SelectField(label="Timezone", choices=TZ_CHOICES, default="UTC") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally started working on the Upcoming Events configuration, but it makes sense to simplify onboarding before doing that work
Codecov Report
@@ Coverage Diff @@
## master #301 +/- ##
==========================================
- Coverage 94.72% 92.51% -2.21%
==========================================
Files 70 69 -1
Lines 2065 2031 -34
==========================================
- Hits 1956 1879 -77
- Misses 109 152 +43
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #296
Also some work for #290
What does this do
Upcoming Events
Why are we doing this
To make it easier for admins to set up Busy Beaver.
How should this be tested
Removed tests, added some tests.
Migrations
We removed the state field
Dependencies
n/a
Callouts
Still need to improve actual text sent to users and shown to users during first-time flow.