Skip to content
This repository has been archived by the owner on Oct 21, 2024. It is now read-only.

Restructure on-boarding from Slack messages to website #301

Merged
merged 11 commits into from
Jul 26, 2020

Conversation

alysivji
Copy link
Member

Part of #296
Also some work for #290

What does this do

  • restructure onboarding flow from Slack-based workflow to Slack message pointing installers to settings website
  • remove onboarding state machine since we don't need it anymore
  • started refactoring settings pages to get ready for settings page for Upcoming Events

Why are we doing this

To make it easier for admins to set up Busy Beaver.

How should this be tested

Removed tests, added some tests.

Migrations

We removed the state field

Dependencies

n/a

Callouts

Still need to improve actual text sent to users and shown to users during first-time flow.


day_of_week = SelectField("Day to post", choices=WEEKDAYS, default="Monday")
post_time = TimeField("Time to post", validators=[DataRequired()])
post_timezone = SelectField(label="Timezone", choices=TZ_CHOICES, default="UTC")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally started working on the Upcoming Events configuration, but it makes sense to simplify onboarding before doing that work

@codecov-commenter
Copy link

Codecov Report

Merging #301 into master will decrease coverage by 2.20%.
The diff coverage is 41.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
- Coverage   94.72%   92.51%   -2.21%     
==========================================
  Files          70       69       -1     
  Lines        2065     2031      -34     
==========================================
- Hits         1956     1879      -77     
- Misses        109      152      +43     
Impacted Files Coverage Δ
busy_beaver/apps/slack_integration/models.py 100.00% <ø> (ø)
...usy_beaver/apps/upcoming_events/upcoming_events.py 100.00% <ø> (ø)
busy_beaver/apps/web/views.py 40.69% <15.62%> (-29.90%) ⬇️
...sy_beaver/apps/slack_integration/oauth/workflow.py 70.49% <22.22%> (-22.27%) ⬇️
busy_beaver/apps/slack_integration/api/oauth.py 100.00% <100.00%> (ø)
...eaver/apps/slack_integration/event_subscription.py 96.25% <100.00%> (+0.55%) ⬆️
busy_beaver/apps/web/forms.py 100.00% <100.00%> (ø)
busy_beaver/common/wrappers/slack.py 95.16% <100.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea5c46...a9d7503. Read the comment docs.

@alysivji alysivji merged commit b680632 into busy-beaver-dev:master Jul 26, 2020
@alysivji alysivji deleted the restructure-onboarding branch July 26, 2020 18:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants