UI polish #460
Open
UI polish #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There looks to be a space missing in this class: obyte-gui-wallet/public/views/walletHome.html Line 656 in 2e9d522 |
|
sorry about that. it's fixed with new commit |
tonyofbyteball
requested changes
Jul 7, 2019
public/views/walletHome.html
Outdated
| <div ng-if="!index.anyOnGoingProcess || 1" style="position: relative;"> | ||
| <div ng-show="index.updateError" ng-click='index.openWallet(); index.updateTxHistory()'> | ||
| <span class="size-12 db m10b">{{index.updateError|translate}}</span> | ||
| <span class="size-13db m10b">{{index.updateError|translate}}</span> |
public/views/walletHome.html
Outdated
| @@ -217,7 +220,7 @@ <h4 ng-show="!index.requiresMultipleSignatures" class="title m0" translate>Unsen | |||
| ng-include="index.txTemplateUrl"> | |||
| </div> | |||
|
|
|||
| <div class="text-gray text-center size-12 p10t" | |||
| <div class="text-gray text-center size-13p10t" | |||
|
There are at least a couple more, I commented in the code. |
- fix headers spacing - improve color selection - button are more proportionated (smaller) - use correct color with gradient in homepage headers - more margin tweaks
|
- remove header bottom white line - reduce the h4 separator height - fix the recipient selector header colors
add back enable_text_select
-Fixed # looks like some top padding is required here, what do you think? -I prefer without it, it’s more standard with native UI # looks odd that "what to send" and "amount" labels are of different size -Fixed # "+ Add fields" seems too close to "who signs", what do you think? - I believe it’s fixed but I have’t Benn able to test in “real life” (I commented out the ng-hide for test) # and whenever you select sending data in "what to send", the Send button seems too close to the bottom of the screen - I will also be cut or under the fold if the signer list get long enough/ To address this we would have to make the button a fixed position and the test of the page scrollable within something like an iframe # the new sent/received tags are so big, they do not look well on iPhone 5 screen (change the width in package.json to 320px to reproduce) I have 0 bytes and no history in my build so I can’t re produce it but it looks like this screen would need some adjustment. # not sure if dollar amount is correctly aligned with green checkmark, what do you think? -I added some offset. Fixed. # "textcoin" tags now get wrapped even on 400px screen - I was not able to reproduce, I have no history. # well, they were wrapped before but at least they kept the padding to the right # when i start typing into the Amount field on the Send tab, the field height suddenly changes - Do you talk about the send page. I don’t observe that. # what made you remove the gradient color from the home screen? - Not on purpose. It has been restored. # when i start typing into the Address field on the Send tab, the field height suddenly changes too - Do you talk about the send page. I don’t observe that. - I also made sure sore url in the witnesses preferences won’t run out of screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS and HTML UI polish: tidied up font sizes, margins and paddings.
Used more gradients to make the app less "flat"