Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: keep names section under RelWithDebInfo build #146

Merged
merged 2 commits into from
Sep 24, 2024
Merged

fix: keep names section under RelWithDebInfo build #146

merged 2 commits into from
Sep 24, 2024

Conversation

guybedford
Copy link
Contributor

This ensures that wasm-opt does not strip the "name" section under RelWithDebugInfo builds (needed for ComponentizeJS).

cfallin
cfallin approved these changes Sep 24, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@guybedford guybedford merged commit 1a8077d into main Sep 24, 2024
4 checks passed
@guybedford guybedford deleted the keep-names branch September 24, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfallin cfallin cfallin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guybedford @cfallin