Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use resolved path in stacks #34

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

guybedford
Copy link
Contributor

This fixes a bug where stacks contain the relative specifiers in errors like:

@./rel-path.js:17:32
[email protected]:69:25
@index.js:53:23

where instead it should be dir/rel-path.js in the stack.

Copy link
Member

@tschneidereit tschneidereit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@tschneidereit tschneidereit merged commit 9da56c2 into bytecodealliance:main Apr 19, 2024
1 check passed
@guybedford guybedford deleted the stack-path-fix branch April 19, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants