Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to WASI 0.2.1 #92

Merged
merged 6 commits into from
Sep 23, 2024
Merged

Conversation

rvolosatovs
Copy link
Member

  1. Ran update-wasi.sh
  2. Manually copied wasi:http 0.2.1, since the script did not update that
  3. Manually updated WIT and rust refs to use 0.2.1
  4. Rebuilt the adapters using build-adapter.sh
  5. Added more error context because I've accidentally updated wasi:config to 0.2.1, which is still in draft - it was really difficult to find the issue without this. Happy to drop the commit and/or split into a separate PR
  6. Updated dependencies

Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
@rvolosatovs
Copy link
Member Author

FWIW, I was unable to use wasi-virt for my use case (bytecodealliance/wasm-tools#1811), but this issue was already reported in May (bytecodealliance/wasm-tools#1565), so it could not have been introduced by this PR

@guybedford
Copy link
Collaborator

Thank you for working through this @rvolosatovs this is great, I appreciate it was a tough upgrade path. The extra error context will definitely help in future too.

Upgrading to WAC instead of wasm-tools compose might be sensible for WASI Virt at this point, as I'm not sure what the maintenance status is for wasm-tools compose (WAC wasn't around when WASI Virt was first written).

@guybedford guybedford merged commit 78cce85 into bytecodealliance:main Sep 23, 2024
2 checks passed
@rvolosatovs rvolosatovs deleted the feat/wasi-0.2.1 branch September 23, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants