Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export wamr_sys. #48

Merged
merged 1 commit into from
Jul 20, 2024
Merged

Conversation

AlixANNERAUD
Copy link
Contributor

I think this won't harm anyone.

@lum1n0us
Copy link
Collaborator

we don't want people use wamr-sys directly. It will be a nightmare to use "C" logic to programming in Rust.

@AlixANNERAUD
Copy link
Contributor Author

AlixANNERAUD commented Jul 19, 2024

Maybe, but in the meantime, this crate is incomplete. We need to allow a minimum of freedom for the end user if they need it (which I'm desperately hoping to have). Alternatively, wamr-sys could be separated from wamr-rust-sdk. Allowing the end user to use or not use wamr-sys doesn't harm anyone because the user's choice is explicit (importing the crate + using the unsafe keyword). Many Rust crates have taken the same initiative.

@lum1n0us
Copy link
Collaborator

Please let me know your requirement. We shall develop new APIs.

@AlixANNERAUD
Copy link
Contributor Author

I proposed the addition of the execution environment, which is necessary for address translation, heap allocation in the Wasm app, setting user data, and address validation. However, this was refused since it wasn't safe. In addition, WAMR C API allows for the creation of thread environments for host created thread.

I understand the will to offer a completely safe API for WAMR, but currently, wamr_rust_sdk cannot fully leverage the capabilities of WAMR, which could be frustrating for end users. This is not a criticism but a fact: the two only maintainers of this repository seem to be already quite occupied with WAMR directly (and I prefer that WAMR is refined before wamr_rust_sdk). I completely understand that wamr_rust_sdk is not yet up to par, but please allow us to at least take advantage of the missing features in wamr_rust_sdk through the C API for now.

@lum1n0us
Copy link
Collaborator

Fair enough. let's do this.

@lum1n0us lum1n0us merged commit 8389dcf into bytecodealliance:main Jul 20, 2024
2 checks passed
@AlixANNERAUD
Copy link
Contributor Author

Thx ☺️

@AlixANNERAUD AlixANNERAUD deleted the Export_WAMR branch July 20, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants