-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to wit-bindgen 0.20.0 #80
Update to wit-bindgen 0.20.0 #80
Conversation
This commit updates the bindings generator to 0.20.0 and refactors the existing support for exporting macros to use the new features of 0.20.0 as well. The `macros` crate feature is now no longer required (yay!) and all the traits to implement are already present in the crate now.
Nice! My only comment is about naming; from an external perspective its a little odd that the macro names don't include the package name. If it was e.g. I don't think its critically important for the |
Good point! I've reverted back to the names you added prior, with one change to rename the |
Makes sense to me. Should the |
Oop yes, good point |
This commit updates the bindings generator to 0.20.0 and refactors the existing support for exporting macros to use the new features of 0.20.0 as well. The
macros
crate feature is now no longer required (yay!) and all the traits to implement are already present in the crate now.