Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to wit-bindgen 0.20.0 #80

Merged
merged 9 commits into from
Mar 5, 2024

Conversation

alexcrichton
Copy link
Member

This commit updates the bindings generator to 0.20.0 and refactors the existing support for exporting macros to use the new features of 0.20.0 as well. The macros crate feature is now no longer required (yay!) and all the traits to implement are already present in the crate now.

This commit updates the bindings generator to 0.20.0 and refactors the
existing support for exporting macros to use the new features of 0.20.0
as well. The `macros` crate feature is now no longer required (yay!) and
all the traits to implement are already present in the crate now.
@alexcrichton
Copy link
Member Author

cc @lann to double-check I'm not missing anything from #77

@lann
Copy link
Contributor

lann commented Feb 29, 2024

Nice!

My only comment is about naming; from an external perspective its a little odd that the macro names don't include the package name. If it was e.g. http_proxy_export it would line up nicely between wasi:http/proxy and wasi::http_proxy_export.

I don't think its critically important for the wasi package itself but this crate probably does set a bit of a precedent for other similar crates.

@alexcrichton
Copy link
Member Author

Good point! I've reverted back to the names you added prior, with one change to rename the incoming_handler module to proxy instead to reflect a bit how the world is wasi:http/proxy. Makes me think I should probably update wit-bindgen to perhaps do this by default.

@lann
Copy link
Contributor

lann commented Feb 29, 2024

Makes sense to me. Should the run mod be renamed to command too?

@alexcrichton
Copy link
Member Author

Oop yes, good point

@sunfishcode sunfishcode merged commit e62af39 into bytecodealliance:main Mar 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants